Re: [PATCH v5 3/7] platform/x86: amd-pmc: call dump registers only once

From: Hans de Goede <hdegoede@redhat.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	mgross@linux.intel.com, rrangel@chromium.org
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v5 3/7] platform/x86: amd-pmc: call dump registers only once
Date: Tue, 6 Jul 2021 11:59:46 +0200	[thread overview]
Message-ID: <5a5fcc11-1fdd-278a-d458-e10954e083b4@redhat.com> (raw)
In-Reply-To: <20210629084803.248498-4-Shyam-sundar.S-k@amd.com>

Hi,

On 6/29/21 10:47 AM, Shyam Sundar S K wrote:
> Currently amd_pmc_dump_registers() routine is being called at
> multiple places. The best to call it is after command submission
> to SMU.
> 
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> ---
> v2: split into multiple patches as suggested by Hans
> v3: No change
> v4: No change
> v5: No change

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

> 
>  drivers/platform/x86/amd-pmc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c
> index b1d6175a13b2..e5107e3b1911 100644
> --- a/drivers/platform/x86/amd-pmc.c
> +++ b/drivers/platform/x86/amd-pmc.c
> @@ -182,6 +182,7 @@ static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, bool set)
>  
>  out_unlock:
>  	mutex_unlock(&dev->lock);
> +	amd_pmc_dump_registers(dev);
>  	return rc;
>  }
>  
> @@ -194,7 +195,6 @@ static int __maybe_unused amd_pmc_suspend(struct device *dev)
>  	if (rc)
>  		dev_err(pdev->dev, "suspend failed\n");
>  
> -	amd_pmc_dump_registers(pdev);
>  	return 0;
>  }
>  
> @@ -207,7 +207,6 @@ static int __maybe_unused amd_pmc_resume(struct device *dev)
>  	if (rc)
>  		dev_err(pdev->dev, "resume failed\n");
>  
> -	amd_pmc_dump_registers(pdev);
>  	return 0;
>  }
>  
> @@ -279,8 +278,6 @@ static int amd_pmc_probe(struct platform_device *pdev)
>  	if (!dev->regbase)
>  		return -ENOMEM;
>  
> -	amd_pmc_dump_registers(dev);
> -
>  	mutex_init(&dev->lock);
>  	platform_set_drvdata(pdev, dev);
>  	amd_pmc_dbgfs_register(dev);
> 