From: Vlastimil Babka <vbabka@suse.cz>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] mm: Constify get_pfnblock_flags_mask and get_pfnblock_migratetype
Date: Fri, 23 Apr 2021 16:59:57 +0200 [thread overview]
Message-ID: <5cb13e53-cd3f-a969-23c8-0e8a0788f242@suse.cz> (raw)
In-Reply-To: <20210416231531.2521383-6-willy@infradead.org>
On 4/17/21 1:15 AM, Matthew Wilcox (Oracle) wrote:
> The struct page is not modified by these routines, so it can be marked
> const.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> include/linux/pageblock-flags.h | 2 +-
> mm/page_alloc.c | 13 +++++++------
> 2 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/include/linux/pageblock-flags.h b/include/linux/pageblock-flags.h
> index fff52ad370c1..973fd731a520 100644
> --- a/include/linux/pageblock-flags.h
> +++ b/include/linux/pageblock-flags.h
> @@ -54,7 +54,7 @@ extern unsigned int pageblock_order;
> /* Forward declaration */
> struct page;
>
> -unsigned long get_pfnblock_flags_mask(struct page *page,
> +unsigned long get_pfnblock_flags_mask(const struct page *page,
> unsigned long pfn,
> unsigned long mask);
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 0152670c6f04..4be2179eedd5 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -474,7 +474,7 @@ static inline bool defer_init(int nid, unsigned long pfn, unsigned long end_pfn)
> #endif
>
> /* Return a pointer to the bitmap storing bits affecting a block of pages */
> -static inline unsigned long *get_pageblock_bitmap(struct page *page,
> +static inline unsigned long *get_pageblock_bitmap(const struct page *page,
> unsigned long pfn)
> {
> #ifdef CONFIG_SPARSEMEM
> @@ -484,7 +484,7 @@ static inline unsigned long *get_pageblock_bitmap(struct page *page,
> #endif /* CONFIG_SPARSEMEM */
> }
>
> -static inline int pfn_to_bitidx(struct page *page, unsigned long pfn)
> +static inline int pfn_to_bitidx(const struct page *page, unsigned long pfn)
> {
> #ifdef CONFIG_SPARSEMEM
> pfn &= (PAGES_PER_SECTION-1);
> @@ -495,7 +495,7 @@ static inline int pfn_to_bitidx(struct page *page, unsigned long pfn)
> }
>
> static __always_inline
> -unsigned long __get_pfnblock_flags_mask(struct page *page,
> +unsigned long __get_pfnblock_flags_mask(const struct page *page,
> unsigned long pfn,
> unsigned long mask)
> {
> @@ -520,13 +520,14 @@ unsigned long __get_pfnblock_flags_mask(struct page *page,
> *
> * Return: pageblock_bits flags
> */
> -unsigned long get_pfnblock_flags_mask(struct page *page, unsigned long pfn,
> - unsigned long mask)
> +unsigned long get_pfnblock_flags_mask(const struct page *page,
> + unsigned long pfn, unsigned long mask)
> {
> return __get_pfnblock_flags_mask(page, pfn, mask);
> }
>
> -static __always_inline int get_pfnblock_migratetype(struct page *page, unsigned long pfn)
> +static __always_inline int get_pfnblock_migratetype(const struct page *page,
> + unsigned long pfn)
> {
> return __get_pfnblock_flags_mask(page, pfn, MIGRATETYPE_MASK);
> }
>
next prev parent reply other threads:[~2021-04-23 15:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 23:15 [RESEND][PATCH 0/6] Constify struct page arguments Matthew Wilcox (Oracle)
2021-04-16 23:15 ` [PATCH 1/6] mm: Make __dump_page static Matthew Wilcox (Oracle)
2021-04-23 14:49 ` Vlastimil Babka
2021-04-27 3:30 ` Anshuman Khandual
2021-04-16 23:15 ` [PATCH 2/6] mm/debug: Factor PagePoisoned out of __dump_page Matthew Wilcox (Oracle)
2021-04-23 14:52 ` Vlastimil Babka
2021-04-27 3:30 ` Anshuman Khandual
2021-04-16 23:15 ` [PATCH 3/6] mm/page_owner: Constify dump_page_owner Matthew Wilcox (Oracle)
2021-04-23 14:53 ` Vlastimil Babka
2021-04-27 3:31 ` Anshuman Khandual
2021-04-16 23:15 ` [PATCH 4/6] mm: Make compound_head const-preserving Matthew Wilcox (Oracle)
2021-04-23 14:58 ` Vlastimil Babka
2021-04-27 3:31 ` Anshuman Khandual
2021-04-16 23:15 ` [PATCH 5/6] mm: Constify get_pfnblock_flags_mask and get_pfnblock_migratetype Matthew Wilcox (Oracle)
2021-04-23 14:59 ` Vlastimil Babka [this message]
2021-04-27 3:32 ` Anshuman Khandual
2021-04-16 23:15 ` [PATCH 6/6] mm: Constify page_count and page_ref_count Matthew Wilcox (Oracle)
2021-04-23 15:01 ` Vlastimil Babka
2021-04-27 3:32 ` Anshuman Khandual
2021-04-17 7:14 ` [RESEND][PATCH 0/6] Constify struct page arguments William Kucharski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cb13e53-cd3f-a969-23c8-0e8a0788f242@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.