All of lore.kernel.org
 help / color / mirror / Atom feed
From: wliang@stu.xidian.edu.cn
To: "Richard Henderson" <richard.henderson@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: Re: Fix a potential Use-after-free bug in handle_simd_shift_fpint_conv() (v6.2.0).
Date: Fri, 25 Feb 2022 12:05:48 +0800 (GMT+08:00)	[thread overview]
Message-ID: <5cca42a6.b21.17f2f0e6d26.Coremail.wliang@stu.xidian.edu.cn> (raw)
In-Reply-To: <3c7903dd-fc50-3b05-8419-0f5011c5e82c@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]


> 
> The fix is correct.  We just need the submission formatted properly, with your 
> Signed-off-by tag.  When re-formatting, you can add my
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 

> r~

Hi guys,

Thank you for waiting for me.

Here is a new patch with Signed-off-by tags.

Best,
Wentao

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-a-potential-Use-after-free-bug-in-handle_simd_sh.patch --]
[-- Type: text/x-patch;  name=0001-Fix-a-potential-Use-after-free-bug-in-handle_simd_sh.patch, Size: 894 bytes --]

From 15129e2cec483a8416738b266bc3b36d56959f69 Mon Sep 17 00:00:00 2001
From: Wentao_Liang <Wentao_Liang_g@163.com>
Date: Fri, 25 Feb 2022 12:01:42 +0800
Subject: [PATCH] Fix a potential Use-after-free bug in
 handle_simd_shift_fpint_conv()

Signed-off-by: Wentao_Liang <Wentao_Liang_g@163.com>
---
 target/arm/translate-a64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 5a1df25f91..d1a59fad9c 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -9045,9 +9045,9 @@ static void handle_simd_shift_fpint_conv(DisasContext *s, bool is_scalar,
         }
     }
 
-    tcg_temp_free_ptr(tcg_fpstatus);
     tcg_temp_free_i32(tcg_shift);
     gen_helper_set_rmode(tcg_rmode, tcg_rmode, tcg_fpstatus);
+    tcg_temp_free_ptr(tcg_fpstatus);
     tcg_temp_free_i32(tcg_rmode);
 }
 
-- 
2.25.1


  reply	other threads:[~2022-02-25  4:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 14:33 Fix a potential Use-after-free bug in handle_simd_shift_fpint_conv() (v6.2.0) wliang
2022-02-23 19:13 ` Richard Henderson
2022-02-25  4:05   ` wliang [this message]
2022-02-25 11:41     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cca42a6.b21.17f2f0e6d26.Coremail.wliang@stu.xidian.edu.cn \
    --to=wliang@stu.xidian.edu.cn \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.