From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Junio C Hamano <gitster@pobox.com>, orgads@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] t5403: Refactor
Date: Sat, 29 Dec 2018 03:06:09 +0000 [thread overview]
Message-ID: <5d3609cd-c934-fd3a-437a-30c6db930093@ramsayjones.plus.com> (raw)
In-Reply-To: <xmqqmuopl1qz.fsf@gitster-ct.c.googlers.com>
On 28/12/2018 22:34, Junio C Hamano wrote:
> orgads@gmail.com writes:
>
>> Subject: Re: [PATCH 1/2] t5403: Refactor
>
[snip]
>> if test "$(git config --bool core.filemode)" = true; then
>
> This is a tangent but this conditional came from an ancient d42ec126
> ("disable post-checkout test on Cygwin", 2009-03-17) that says
>
> disable post-checkout test on Cygwin
>
> It is broken because of the tricks we have to play with
> lstat to get the bearable perfomance out of the call.
> Sadly, it disables access to Cygwin's executable attribute,
> which Windows filesystems do not have at all.
>
> I wonder if this is still relevant these days (Cc'ed Ramsay for
> input).
Ah, no, the 'tricks we have to play with lstat' mentioned in that
commit message are long gone! ;-) If you remove that conditional,
then the test passes just fine.
ATB,
Ramsay Jones
next prev parent reply other threads:[~2018-12-29 4:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-24 21:24 [PATCH] Rebase: Run post-checkout hook on checkout orgads
2018-12-24 21:24 ` [PATCH 1/2] t5403: Refactor orgads
2018-12-28 22:34 ` Junio C Hamano
2018-12-29 3:06 ` Ramsay Jones [this message]
2018-12-29 21:36 ` Orgad Shaneh
2018-12-24 21:24 ` [PATCH 2/2] Rebase: Run post-checkout hook on checkout orgads
2018-12-28 22:53 ` Junio C Hamano
2018-12-29 21:31 ` Orgad Shaneh
-- strict thread matches above, loose matches on Subject: below --
2018-12-20 21:55 [PATCH 1/2] t5403: Refactor orgads
2018-12-20 21:48 orgads
2018-12-21 16:06 ` Johannes Schindelin
[not found] ` <CAGHpTB+9L55Gvezhb7x6Kb49WS_nfzmKdVvpH3_=6GM7y8YQ_g@mail.gmail.com>
2018-12-24 20:54 ` Orgad Shaneh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d3609cd-c934-fd3a-437a-30c6db930093@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.