From: Stephen Boyd <swboyd@chromium.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>
Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
Andrey Pronin <apronin@chromium.org>,
Duncan Laurie <dlaurie@chromium.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
Alexander Steffen <Alexander.Steffen@infineon.com>
Subject: Re: [PATCH v3 1/4] tpm: Add a flag to indicate TPM power is managed by firmware
Date: Mon, 12 Aug 2019 07:11:48 -0700 [thread overview]
Message-ID: <5d5173a6.1c69fb81.3bbe4.6118@mx.google.com> (raw)
In-Reply-To: <93400d11833bd42c4be0b846416ff1f469904784.camel@linux.intel.com>
Quoting Jarkko Sakkinen (2019-08-09 11:02:01)
> On Tue, 2019-08-06 at 15:07 -0700, Stephen Boyd wrote:
> > On some platforms, the TPM power is managed by firmware and therefore we
> > don't need to stop the TPM on suspend when going to a light version of
> > suspend such as S0ix ("freeze" suspend state). Add a chip flag to
> > indicate this so that certain platforms can probe for the usage of this
> > light suspend and avoid touching the TPM state across suspend/resume.
>
> The commit message should mention the new constant.
Alright.
>
> > + if (chip->flags & TPM_CHIP_FLAG_FIRMWARE_POWER_MANAGED)
> > + if (!pm_suspend_via_firmware())
>
> Why both checks are needed?
>
> If both checks are needed, you could write it as a single
> conditional statement:
>
> if (chip->flags & TPM_CHIP_FLAG_FIRMWARE_POWER_MANAGED &&
> !pm_suspend_via_firmware())
>
Ok. I'll combine them.
next prev parent reply other threads:[~2019-08-12 14:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 22:07 [PATCH v3 0/4] tpm: Add driver for cr50 Stephen Boyd
2019-08-06 22:07 ` [PATCH v3 1/4] tpm: Add a flag to indicate TPM power is managed by firmware Stephen Boyd
2019-08-09 18:02 ` Jarkko Sakkinen
2019-08-12 14:11 ` Stephen Boyd [this message]
2019-08-06 22:07 ` [PATCH v3 2/4] tpm: tpm_tis_spi: Export functionality to other drivers Stephen Boyd
2019-08-09 20:28 ` Jarkko Sakkinen
2019-08-12 14:16 ` Stephen Boyd
2019-08-06 22:07 ` [PATCH v3 3/4] dt-bindings: tpm: document properties for cr50 Stephen Boyd
2019-08-06 22:07 ` [PATCH v3 4/4] tpm: add driver for cr50 on SPI Stephen Boyd
2019-08-09 20:31 ` Jarkko Sakkinen
2019-08-12 20:46 ` Stephen Boyd
2019-08-15 13:00 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5173a6.1c69fb81.3bbe4.6118@mx.google.com \
--to=swboyd@chromium.org \
--cc=Alexander.Steffen@infineon.com \
--cc=apronin@chromium.org \
--cc=arnd@arndb.de \
--cc=dlaurie@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.