Re: [PATCH v6 4/5] tty: serial: qcom_geni_serial: Wakeup over UART RX

From: Stephen Boyd <swboyd@chromium.org>
To: Akash Asthana <akashast@codeaurora.org>, gregkh@linuxfoundation.org
Cc: mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-serial@vger.kernel.org,
	Akash Asthana <akashast@codeaurora.org>
Subject: Re: [PATCH v6 4/5] tty: serial: qcom_geni_serial: Wakeup over UART RX
Date: Fri, 22 Nov 2019 10:22:48 -0800	[thread overview]
Message-ID: <5dd82779.1c69fb81.c1de1.90e5@mx.google.com> (raw)
In-Reply-To: <0101016e937a5b83-1c5c4e0e-ae63-447a-8724-52477b11dff4-000000@us-west-2.amazonses.com>

Quoting Akash Asthana (2019-11-22 06:18:19)
> Add system wakeup capability over UART RX line for wakeup capable UART.
> When system is suspended, RX line act as an interrupt to wakeup system
> for any communication requests from peer.
> 
> Signed-off-by: Akash Asthana <akashast@codeaurora.org>

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

One question below.

> @@ -1330,6 +1354,10 @@ static int qcom_geni_serial_remove(struct platform_device *pdev)
>         struct uart_driver *drv = port->uport.private_data;
>  
>         uart_remove_one_port(drv, &port->uport);
> +
> +       device_init_wakeup(&pdev->dev, false);
> +       dev_pm_clear_wake_irq(&pdev->dev);

Should this order be swapped? Usually remove is done in reverse of probe
order, so clear_wake_irq, init wakeup, and remove uart port. I'm not
convinced it will actually matter though so maybe this isn't a problem.