From: Johannes Sixt <j6t@kdbg.org>
To: "Chris Torek" <chris.torek@gmail.com>, "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] connected: use buffered I/O to talk to rev-list
Date: Mon, 3 Aug 2020 20:17:34 +0200 [thread overview]
Message-ID: <5de5acdf-382b-6907-4a64-02ae02abaf13@kdbg.org> (raw)
In-Reply-To: <CAPx1Gvesmwf_CBj6D=YriFQgtEsDyUe7PHa6p9AvxG=fwAvHpA@mail.gmail.com>
Am 02.08.20 um 18:08 schrieb Chris Torek:
> On Sun, Aug 2, 2020 at 7:39 AM René Scharfe <l.s.r@web.de> wrote:
>> @@ -135,16 +135,10 @@ int check_connected(oid_iterate_fn fn, void *cb_data,
>> if (new_pack && find_pack_entry_one(oid.hash, new_pack))
>> continue;
>>
>> - memcpy(commit, oid_to_hex(&oid), hexsz);
>> - if (write_in_full(rev_list.in, commit, hexsz + 1) < 0) {
>> - if (errno != EPIPE && errno != EINVAL)
>> - error_errno(_("failed write to rev-list"));
>> - err = -1;
>> - break;
>> - }
>> + fprintf(rev_list_in, "%s\n", oid_to_hex(&oid));
>> } while (!fn(cb_data, &oid));
>>
>> - if (close(rev_list.in))
>> + if (fclose(rev_list_in))
>> err = error_errno(_("failed to close rev-list's stdin"));
>>
>> sigchain_pop(SIGPIPE);
>
> The same ferror()-before-fclose() remarks apply here too,
> but this time the explicit errno checking (EPIPE) cannot
> be done -- it's too late, errno is probably overwritten.
The EPIPE check should really remain in the loop above. (Same comment on
EPIPE on Windows applies here.)
-- Hannes
next prev parent reply other threads:[~2020-08-03 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 14:38 [PATCH] connected: use buffered I/O to talk to rev-list René Scharfe
2020-08-02 16:08 ` Chris Torek
2020-08-03 18:17 ` Johannes Sixt [this message]
2020-08-12 16:52 ` [PATCH v2] " René Scharfe
2020-08-13 9:16 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5de5acdf-382b-6907-4a64-02ae02abaf13@kdbg.org \
--to=j6t@kdbg.org \
--cc=chris.torek@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.