From: Larry Finger <Larry.Finger@lwfinger.net>
To: yhchuang@realtek.com, kvalo@codeaurora.org
Cc: kernel@iuliancostan.com, linux-wireless@vger.kernel.org,
i@outv.im, trevor@shartrec.com
Subject: Re: [PATCH v1] rtw88: pci: disable aspm for platform inter-op with module parameter
Date: Sat, 20 Jun 2020 14:53:15 -0500 [thread overview]
Message-ID: <5def4c90-5143-68f1-201f-b0590f85dde6@lwfinger.net> (raw)
In-Reply-To: <20200605074703.32726-1-yhchuang@realtek.com>
On 6/5/20 2:47 AM, yhchuang@realtek.com wrote:
> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> Some platforms cannot read the DBI register successfully for the
> ASPM settings. After the read failed, the bus could be unstable,
> and the device just became unavailable [1]. For those platforms,
> the ASPM should be disabled. But as the ASPM can help the driver
> to save the power consumption in power save mode, the ASPM is still
> needed. So, add a module parameter for them to disable it, then
> the device can still work, while others can benefit from the less
> power consumption that brings by ASPM enabled.
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=206411
> [2] Note that my lenovo T430 is the same.
As someone who maintains these drivers in a GitHub repo so that users of older
kernels can have access to them, I am in favor of this module option. Only a
very few cases would need to disable ASPM, and I see no reason for everyone else
to use additional power as would be needed with automatic disabling. Adding a
new machine to some quirk list would be more difficult than merely telling a
novice user how to turn ASPM off for their system.
In case someone is collecting machines that would need a quirk, I found another
one as shown in https://github.com/lwfinger/rtlwifi_new/issues/622. That one is
a Lenovo Thinkpad E490.
Larry
next prev parent reply other threads:[~2020-06-20 19:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 7:47 [PATCH v1] rtw88: pci: disable aspm for platform inter-op with module parameter yhchuang
2020-06-10 21:37 ` Sebastian Andrzej Siewior
2020-06-16 11:06 ` Tony Chuang
2020-06-16 13:35 ` Sebastian Andrzej Siewior
2020-06-17 5:30 ` Tony Chuang
2020-06-17 7:29 ` Sebastian Andrzej Siewior
2020-07-15 9:00 ` Kalle Valo
2020-07-15 9:31 ` Tony Chuang
2020-06-20 19:53 ` Larry Finger [this message]
2020-07-15 9:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5def4c90-5143-68f1-201f-b0590f85dde6@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=i@outv.im \
--cc=kernel@iuliancostan.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=trevor@shartrec.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.