From: John Fastabend <john.fastabend@gmail.com>
To: Yoshiki Komachi <komachi.yoshiki@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
Petar Penkov <ppenkov.kernel@gmail.com>
Cc: Yoshiki Komachi <komachi.yoshiki@gmail.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: RE: [PATCH v2 bpf 1/2] flow_dissector: Fix to use new variables for port ranges in bpf hook
Date: Fri, 17 Jan 2020 22:59:51 -0800 [thread overview]
Message-ID: <5e22ace73625b_33062b1a40ed85c0af@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20200117070533.402240-2-komachi.yoshiki@gmail.com>
Yoshiki Komachi wrote:
> This patch applies new flag (FLOW_DISSECTOR_KEY_PORTS_RANGE) and
> field (tp_range) to BPF flow dissector to generate appropriate flow
> keys when classified by specified port ranges.
>
> Fixes: 8ffb055beae5 ("cls_flower: Fix the behavior using port ranges with hw-offload")
> Signed-off-by: Yoshiki Komachi <komachi.yoshiki@gmail.com>
> ---
> net/core/flow_dissector.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
> index 2dbbb03..cc32d1d 100644
LGTM
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2020-01-18 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 7:05 [PATCH v2 bpf 0/2] Fix the classification based on port ranges in bpf hook Yoshiki Komachi
2020-01-17 7:05 ` [PATCH v2 bpf 1/2] flow_dissector: Fix to use new variables for " Yoshiki Komachi
2020-01-17 17:00 ` Petar Penkov
2020-01-18 6:59 ` John Fastabend [this message]
2020-01-17 7:05 ` [PATCH v2 bpf 2/2] selftests/bpf: Add test based on port range for BPF flow dissector Yoshiki Komachi
2020-01-18 7:05 ` John Fastabend
2020-01-22 10:29 ` [PATCH v2 bpf 0/2] Fix the classification based on port ranges in bpf hook Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e22ace73625b_33062b1a40ed85c0af@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=komachi.yoshiki@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ppenkov.kernel@gmail.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.