From: zhuyinbo <zhuyinbo@loongson.cn>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Jianmin Lv <lvjianmin@loongson.cn>,
Liu Peibao <liupeibao@loongson.cn>,
wanghongliang@loongson.cn, loongson-kernel@lists.loongnix.cn,
zhuyinbo@loongson.cn
Subject: Re: [PATCH v13 1/2] dt-bindings: clock: add loongson-2 boot clock index
Date: Wed, 8 Mar 2023 09:35:50 +0800 [thread overview]
Message-ID: <5e9b3bd5-d885-6237-5e14-2becb3c956cc@loongson.cn> (raw)
In-Reply-To: <692a62da-a9a1-fa23-6e24-723d73c3a423@linaro.org>
在 2023/3/7 下午8:47, Krzysztof Kozlowski 写道:
> On 07/03/2023 12:50, Yinbo Zhu wrote:
>> The Loongson-2 boot clock was used to spi and lio peripheral and
>> this patch was to add boot clock index number.
>>
>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
>> ---
> This is v13? Where is the changelog then?
in fact, this is a new patch(v1), but another clock driver patch in
this series had send as v13 and need depend on
this patch so set current patch as v13.
>
>
>> include/dt-bindings/clock/loongson,ls2k-clk.h | 25 ++++++++++---------
>> 1 file changed, 13 insertions(+), 12 deletions(-)
>>
>> diff --git a/include/dt-bindings/clock/loongson,ls2k-clk.h b/include/dt-bindings/clock/loongson,ls2k-clk.h
>> index db1e27e792ff1..e86804365e506 100644
>> --- a/include/dt-bindings/clock/loongson,ls2k-clk.h
>> +++ b/include/dt-bindings/clock/loongson,ls2k-clk.h
>> @@ -13,17 +13,18 @@
>> #define LOONGSON2_DC_PLL 3
>> #define LOONGSON2_PIX0_PLL 4
>> #define LOONGSON2_PIX1_PLL 5
>> -#define LOONGSON2_NODE_CLK 6
>> -#define LOONGSON2_HDA_CLK 7
>> -#define LOONGSON2_GPU_CLK 8
>> -#define LOONGSON2_DDR_CLK 9
>> -#define LOONGSON2_GMAC_CLK 10
>> -#define LOONGSON2_DC_CLK 11
>> -#define LOONGSON2_APB_CLK 12
>> -#define LOONGSON2_USB_CLK 13
>> -#define LOONGSON2_SATA_CLK 14
>> -#define LOONGSON2_PIX0_CLK 15
>> -#define LOONGSON2_PIX1_CLK 16
>> -#define LOONGSON2_CLK_END 17
>> +#define LOONGSON2_BOOT_CLK 6
> That's an ABI break and commit msg does not explain it.
you meaning is that need add a explanation in commit msg that why
LOONGSON2_BOOT_CLK was added after LOONGSON2_PIX1_PLL and not add it in ending, right?
>
>> +#define LOONGSON2_NODE_CLK 7
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2023-03-08 1:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 11:50 [PATCH v13 1/2] dt-bindings: clock: add loongson-2 boot clock index Yinbo Zhu
2023-03-07 11:50 ` [PATCH v13 2/2] clk: clk-loongson2: add clock controller driver support Yinbo Zhu
2023-03-08 12:16 ` kernel test robot
2023-03-09 2:58 ` zhuyinbo
2023-03-09 3:18 ` zhuyinbo
2023-03-09 6:09 ` Krzysztof Kozlowski
2023-03-09 6:27 ` zhuyinbo
2023-03-09 6:37 ` Krzysztof Kozlowski
2023-03-09 6:09 ` Krzysztof Kozlowski
2023-03-09 23:47 ` Stephen Boyd
2023-03-10 8:42 ` Krzysztof Kozlowski
2023-03-13 18:20 ` Stephen Boyd
2023-03-14 1:07 ` zhuyinbo
2023-03-14 6:49 ` Krzysztof Kozlowski
2023-03-15 0:26 ` Stephen Boyd
2023-03-07 12:47 ` [PATCH v13 1/2] dt-bindings: clock: add loongson-2 boot clock index Krzysztof Kozlowski
2023-03-08 1:35 ` zhuyinbo [this message]
2023-03-08 8:37 ` Krzysztof Kozlowski
2023-03-08 9:24 ` zhuyinbo
2023-03-08 10:38 ` Krzysztof Kozlowski
2023-03-09 1:43 ` zhuyinbo
2023-03-09 6:25 ` Krzysztof Kozlowski
2023-03-09 12:44 ` zhuyinbo
2023-03-09 16:12 ` Krzysztof Kozlowski
2023-03-10 2:07 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e9b3bd5-d885-6237-5e14-2becb3c956cc@loongson.cn \
--to=zhuyinbo@loongson.cn \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wanghongliang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.