From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: f.ebner@proxmox.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] block: Remove unnecessary NULL check in bdrv_pad_request()
Date: Thu, 28 Mar 2024 12:24:40 +0100 [thread overview]
Message-ID: <5f6f92e8-b30f-4021-86ec-41945e6c0342@linaro.org> (raw)
In-Reply-To: <20240327192750.204197-1-kwolf@redhat.com>
On 27/3/24 20:27, Kevin Wolf wrote:
> Coverity complains that the check introduced in commit 3f934817 suggests
> that qiov could be NULL and we dereference it before reaching the check.
> In fact, all of the callers pass a non-NULL pointer, so just remove the
> misleading check.
>
> Resolves: Coverity CID 1542668
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-03-28 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 19:27 [PATCH] block: Remove unnecessary NULL check in bdrv_pad_request() Kevin Wolf
2024-03-28 10:35 ` Fiona Ebner
2024-03-28 11:24 ` Philippe Mathieu-Daudé [this message]
2024-04-02 10:53 ` Philippe Mathieu-Daudé
2024-04-02 12:38 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f6f92e8-b30f-4021-86ec-41945e6c0342@linaro.org \
--to=philmd@linaro.org \
--cc=f.ebner@proxmox.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.