From: Markus Elfring <Markus.Elfring@web.de>
To: Aditya Pakki <pakki001@umn.edu>, linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>,
Kangjie Lu <kjlu@umn.edu>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] media: saa7146: Avoid using BUG_ON as an assertion
Date: Mon, 16 Dec 2019 11:22:33 +0100 [thread overview]
Message-ID: <5f75a571-c3f7-4bc1-9f43-a2d0460dab16@web.de> (raw)
In-Reply-To: <20191215192133.3765-1-pakki001@umn.edu>
…
> +++ b/drivers/media/common/saa7146/saa7146_video.c
@@ -345,7 +345,8 @@ static int video_begin(struct saa7146_fh *fh)
…
- BUG_ON(NULL == fmt);
+ if (NULL == fmt)
…
Would you like to express a null pointer check in a succinct way?
+ if (!fmt)
Will the tag “Fixes” become helpful for the change description?
Regards,
Markus
prev parent reply other threads:[~2019-12-16 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 19:21 [PATCH] media: saa7146: Avoid using BUG_ON as an assertion Aditya Pakki
2019-12-16 10:22 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f75a571-c3f7-4bc1-9f43-a2d0460dab16@web.de \
--to=markus.elfring@web.de \
--cc=hverkuil@xs4all.nl \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.