From: Hans de Goede <hdegoede@redhat.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>
Cc: markgross@kernel.org, Sanket.Goswami@amd.com,
mario.limonciello@amd.com, platform-driver-x86@vger.kernel.org,
Harsh Jain <Harsh.Jain@amd.com>
Subject: Re: [PATCH v4 2/2] platform/x86/amd/pmc: Add dump_custom_stb module parameter
Date: Thu, 5 Oct 2023 12:51:06 +0200 [thread overview]
Message-ID: <5f8ce053-cc9e-e6b2-c2ba-f62df30cb3ab@redhat.com> (raw)
In-Reply-To: <6d9a33d-3c92-3e24-3843-1084af1f516b@linux.intel.com>
Hi,
On 10/5/23 12:15, Ilpo Järvinen wrote:
> On Wed, 4 Oct 2023, Hans de Goede wrote:
>> On 10/4/23 14:11, Shyam Sundar S K wrote:
>>> Thank you for the detailed feedback. I will make these changes and see
>>> if that helps - will need some time do tests and come back on this.
>>>
>>> Meanwhile, is it OK for you to take changes in v4 1/2 atleast? So that
>>> I don't need to respin it again (assuming there are no remarks for 1/2).
>>
>> Note I have a new pdx86 co-maintainer Ilpo who is merging the patches
>> leading up to the 6.7 merge window (Ilpo and I plan to take turns for this).
>>
>> IMHO it will be easier for Ilpo to merge the whole series in one
>> go when it is ready.
>
> I can take single patches just as easily as the whole series as my tools
> anyway explode the whole series into individual patches as an intermediate
> step.
>
> I'll look into it tomorrow. There seemed to be one whitespace issue in the
> debug print but I can deal with that myself while applying but other than
> that, 1/2 seems fine to me.
>
> (In general, I personally prefer forward progress over posting the same
> patches over and over because something in the same serie requires more
> work).
Ok that works for me too.
>> Note when addressing my remarks please split any fixes for the existing
>> functionality out into separate patches vs the new dump_custom_stb
>> support.
>
> Also, the kzalloc() move + ->fsize addition could be in own patch so the
> actual dump_custom_stb patch itself becomes a lot simpler than it
> currently is.
Yes that really should be a separate patch too.
Regards,
Hans
next prev parent reply other threads:[~2023-10-05 14:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 14:20 [PATCH v4 1/2] platform/x86/amd/pmc: Add PMFW command id to support S2D force flush Shyam Sundar S K
2023-09-10 14:20 ` [PATCH v4 2/2] platform/x86/amd/pmc: Add dump_custom_stb module parameter Shyam Sundar S K
2023-09-18 12:27 ` Hans de Goede
2023-09-25 10:48 ` Shyam Sundar S K
2023-10-04 9:14 ` Hans de Goede
2023-10-04 12:11 ` Shyam Sundar S K
2023-10-04 15:10 ` Hans de Goede
2023-10-05 10:15 ` Ilpo Järvinen
2023-10-05 10:51 ` Hans de Goede [this message]
2023-10-06 10:27 ` Ilpo Järvinen
2023-10-09 5:57 ` Shyam Sundar S K
2023-10-09 9:25 ` Shyam Sundar S K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f8ce053-cc9e-e6b2-c2ba-f62df30cb3ab@redhat.com \
--to=hdegoede@redhat.com \
--cc=Harsh.Jain@amd.com \
--cc=Sanket.Goswami@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.