From: Maor Gottlieb <maorg@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>, <linux-kernel@vger.kernel.org>,
<linux-rdma@vger.kernel.org>
Subject: Re: [PATCH rdma-next 2/4] lib/scatterlist: Add support in dynamically allocation of SG entries
Date: Mon, 7 Sep 2020 15:34:28 +0300 [thread overview]
Message-ID: <5fe4d1ce-2c08-ebc1-5b05-3bb051b35069@nvidia.com> (raw)
In-Reply-To: <20200907072916.GB19875@lst.de>
On 9/7/2020 10:29 AM, Christoph Hellwig wrote:
>> +static inline void _sg_chain(struct scatterlist *chain_sg,
>> + struct scatterlist *sgl)
>> +{
>> + /*
>> + * offset and length are unused for chain entry. Clear them.
>> + */
>> + chain_sg->offset = 0;
>> + chain_sg->length = 0;
>> +
>> + /*
>> + * Set lowest bit to indicate a link pointer, and make sure to clear
>> + * the termination bit if it happens to be set.
>> + */
>> + chain_sg->page_link = ((unsigned long) sgl | SG_CHAIN) & ~SG_END;
>> +}
> Please call this __sg_chain to stick with our normal kernel naming
> convention.
Will do.
next prev parent reply other threads:[~2020-09-07 12:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 12:18 [PATCH rdma-next 0/4] scatterlist: add sg_alloc_table_append function Leon Romanovsky
2020-09-03 12:18 ` [PATCH rdma-next 2/4] lib/scatterlist: Add support in dynamically allocation of SG entries Leon Romanovsky
2020-09-07 7:29 ` Christoph Hellwig
2020-09-07 12:34 ` Maor Gottlieb [this message]
2020-09-03 12:18 ` [PATCH rdma-next 3/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages Leon Romanovsky
2020-09-07 7:29 ` Christoph Hellwig
2020-09-07 12:44 ` Maor Gottlieb
2020-09-08 15:54 ` Christoph Hellwig
2020-09-08 16:13 ` Jason Gunthorpe
2020-09-03 12:18 ` [PATCH rdma-next 4/4] RDMA/umem: Move to allocate " Leon Romanovsky
2020-09-07 7:29 ` Christoph Hellwig
2020-09-08 14:10 ` Jason Gunthorpe
2020-09-03 15:32 ` [PATCH rdma-next 0/4] scatterlist: add sg_alloc_table_append function Christoph Hellwig
2020-09-03 15:55 ` Leon Romanovsky
2020-09-03 15:54 ` [PATCH rdma-next 1/4] lib/scatterlist: Refactor sg_alloc_table_from_pages Leon Romanovsky
2020-09-07 7:29 ` Christoph Hellwig
2020-09-07 12:32 ` Maor Gottlieb
2020-09-08 15:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fe4d1ce-2c08-ebc1-5b05-3bb051b35069@nvidia.com \
--to=maorg@nvidia.com \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.