All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>, kbuild test robot <lkp@intel.com>
Cc: liam.r.girdwood@linux.intel.com, vkoul@kernel.org,
	alsa-devel@alsa-project.org, broonie@kernel.org,
	kbuild-all@01.org
Subject: Re: [PATCH] ALSA: memalloc: declare snd_sgbuf_aligned_pages() unconditionally
Date: Fri, 27 Jul 2018 09:54:20 -0500	[thread overview]
Message-ID: <60099a07-aedd-e1c3-e0f1-6af46da69901@linux.intel.com> (raw)
In-Reply-To: <s5hfu05uuts.wl-tiwai@suse.de>

On 7/27/18 12:11 AM, Takashi Iwai wrote:
> On Thu, 26 Jul 2018 16:51:55 +0200,
> kbuild test robot wrote:
>>
>> Hi Pierre-Louis,
>>
>> I love your patch! Yet something to improve:
>>
>> [auto build test ERROR on sound/for-next]
>> [also build test ERROR on v4.18-rc6 next-20180725]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>
>> url:    https://github.com/0day-ci/linux/commits/Pierre-Louis-Bossart/ALSA-memalloc-declare-snd_sgbuf_aligned_pages-unconditionally/20180726-192035
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
>> config: alpha-allyesconfig (attached as .config)
>> compiler: alpha-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>> reproduce:
>>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>          chmod +x ~/bin/make.cross
>>          # save the attached .config to linux build tree
>>          GCC_VERSION=7.2.0 make.cross ARCH=alpha
>>
>> All errors (new ones prefixed by >>):
>>
>>     In file included from include/sound/pcm.h:27:0,
>>                      from sound/core/pcm_iec958.c:11:
>>     include/sound/memalloc.h: In function 'snd_sgbuf_aligned_pages':
>>>> include/sound/memalloc.h:75:17: error: 'PAGE_SIZE' undeclared (first use in this function); did you mean 'TASK_SIZE'?
>>       return (size + PAGE_SIZE - 1) >> PAGE_SHIFT;
>>                      ^~~~~~~~~
>>                      TASK_SIZE
> 
> OK, we need to include <asm/page.h> in this header file.
> 
> Pierre, care to resend with the fix?

yes, will do later today.

  reply	other threads:[~2018-07-27 14:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 20:15 [PATCH] ALSA: memalloc: declare snd_sgbuf_aligned_pages() unconditionally Pierre-Louis Bossart
2018-07-26  6:28 ` Takashi Iwai
2018-07-26 16:08   ` Mark Brown
2018-07-26 14:51 ` kbuild test robot
2018-07-27  5:11   ` Takashi Iwai
2018-07-27 14:54     ` Pierre-Louis Bossart [this message]
2018-07-26 16:12 ` Applied "ALSA: memalloc: declare snd_sgbuf_aligned_pages() unconditionally" to the asoc tree Mark Brown
2018-07-27  1:00 ` [PATCH] ALSA: memalloc: declare snd_sgbuf_aligned_pages() unconditionally kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60099a07-aedd-e1c3-e0f1-6af46da69901@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kbuild-all@01.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=lkp@intel.com \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.