Re: [Qemu-devel] [PATCH] configure: fix pam test warning - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
	qemu-devel@nongnu.org, berrange@redhat.com
Subject: Re: [Qemu-devel] [PATCH] configure: fix pam test warning
Date: Thu, 4 Apr 2019 15:55:05 +0200	[thread overview]
Message-ID: <600f1565-9e14-a8a3-4692-4454dce0164b@redhat.com> (raw)
In-Reply-To: <20190404091725.20595-1-dgilbert@redhat.com>

On 4/4/19 11:17 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> The pam test generates a warning on Fedora 29 with -O3 compilation
> because the headers declare that the pam_conversation pointer to
> pam_start must be non-NULL.  Change it to use the same 0 initialised
> structure as we actually use in qauthz.
> 
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 1c563a7027..73f7ad2be0 100755
> --- a/configure
> +++ b/configure
> @@ -2946,9 +2946,9 @@ if test "$auth_pam" != "no"; then
>  int main(void) {
>     const char *service_name = "qemu";
>     const char *user = "frank";
> -   const struct pam_conv *pam_conv = NULL;
> +   const struct pam_conv pam_conv = { 0 };
>     pam_handle_t *pamh = NULL;
> -   pam_start(service_name, user, pam_conv, &pamh);
> +   pam_start(service_name, user, &pam_conv, &pamh);
>     return 0;
>  }
>  EOF
>