From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: Julien Grall <jgrall@amazon.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two)
Date: Mon, 28 Feb 2022 10:09:44 +0000 [thread overview]
Message-ID: <60244b45-1b47-acc1-9658-fb260394adc7@xen.org> (raw)
In-Reply-To: <20220228100826.61339-1-julien@xen.org>
On 28/02/2022 10:08, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> Commit 13c03002c5df ("xen/arm64: head: Mark the end of subroutines
> with ENDPROC") intended to mark all the subroutines with ENDPROC.
>
> Unfortunately, I missed fail(), switch_ttbr() and init_uart(). Add
> ENDPROC for the benefits of static analysis tools and the reader.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
Hmmm... It looks like I sent this patch twice. Please ignore this
version and instead review:
https://lore.kernel.org/xen-devel/20220228100805.60918-1-julien@xen.org/
> ---
> xen/arch/arm/arm64/head.S | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 314b800b3f8e..66d862fc8137 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -800,6 +800,7 @@ ENDPROC(launch)
> fail: PRINT("- Boot failed -\r\n")
> 1: wfe
> b 1b
> +ENDPROC(fail)
>
> GLOBAL(_end_boot)
>
> @@ -830,6 +831,7 @@ ENTRY(switch_ttbr)
> isb
>
> ret
> +ENDPROC(switch_ttbr)
>
> #ifdef CONFIG_EARLY_PRINTK
> /*
> @@ -847,6 +849,7 @@ init_uart:
> #endif
> PRINT("- UART enabled -\r\n")
> ret
> +ENDPROC(init_uart)
>
> /* Print early debug messages.
> * x0: Nul-terminated string to print.
--
Julien Grall
next prev parent reply other threads:[~2022-02-28 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 10:08 [PATCH] xen/arm64: head: Mark the end of subroutines with ENDPROC (take two) Julien Grall
2022-02-28 10:09 ` Julien Grall [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-28 10:08 Julien Grall
2022-02-28 12:51 ` Michal Orzel
2022-03-01 14:56 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60244b45-1b47-acc1-9658-fb260394adc7@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=jgrall@amazon.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.