From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Felipe Contreras" <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"Martin Ågren" <martin.agren@gmail.com>,
"brian m . carlson" <sandals@crustytoothpaste.net>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 5/8] doc: remove redundant rm
Date: Thu, 13 May 2021 13:58:41 -0500 [thread overview]
Message-ID: <609d76e1ae327_42a0208bd@natae.notmuch> (raw)
In-Reply-To: <878s4islld.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> On Wed, May 12 2021, Felipe Contreras wrote:
>
> > It's not clear what it was supposed to achieve.
>
> It seems this used to make sense around 7b8a74f39cb (Documentation:
> Replace @@GIT_VERSION@@ in documentation, 2007-03-25), but at some point
> (I didn't look further) we refactored that and kept the "rm".
Actually it came later: 50cff52f1a (When generating manpages, delete
outdated targets first., 2007-08-02).
I'm not sure we should complicate the Makefile just because somebody
made the mistake of doing 'sudo make doc' a long time. Especially since
other rules don't have this.
sudo make doc
touch GIT-ASCIIDOCFLAGS
make doc
Fails here already.
asciidoc: FAILED: api-merge.txt: line 2: unexpected error:
asciidoc: ------------------------------------------------------------
Traceback (most recent call last):
File "/usr/bin/asciidoc", line 6247, in asciidoc
writer.open(outfile, reader.bom)
File "/usr/bin/asciidoc", line 4633, in open
self.f = open(fname, 'w+', encoding='utf-8', newline="")
PermissionError: [Errno 13] Permission denied: '.../Documentation/technical/api-merge.html'
--
Felipe Contreras
next prev parent reply other threads:[~2021-05-13 18:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 22:27 [PATCH 0/8] doc: asciidoc cleanups Felipe Contreras
2021-05-12 22:27 ` [PATCH 1/8] doc: standardize asciidoc calls Felipe Contreras
2021-05-12 22:27 ` [PATCH 2/8] doc: add an asciidoc helper Felipe Contreras
2021-05-13 15:17 ` Ævar Arnfjörð Bjarmason
2021-05-13 19:33 ` Felipe Contreras
2021-05-13 21:43 ` Junio C Hamano
2021-05-12 22:27 ` [PATCH 3/8] doc: disable asciidoc-helper for asciidoctor Felipe Contreras
2021-05-12 22:27 ` [PATCH 4/8] doc: simplify the handling of interruptions Felipe Contreras
2021-05-13 5:19 ` Junio C Hamano
2021-05-13 6:10 ` Felipe Contreras
2021-05-12 22:28 ` [PATCH 5/8] doc: remove redundant rm Felipe Contreras
2021-05-13 15:22 ` Ævar Arnfjörð Bjarmason
2021-05-13 18:58 ` Felipe Contreras [this message]
2021-05-12 22:28 ` [PATCH 6/8] doc: refactor common dependencies Felipe Contreras
2021-05-12 22:28 ` [PATCH 7/8] doc: improve asciidoc dependencies Felipe Contreras
2021-05-13 17:43 ` Martin Ågren
2021-05-12 22:28 ` [PATCH 8/8] doc: join xml and man rules Felipe Contreras
2021-05-13 11:02 ` Martin Ågren
2021-05-13 11:15 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=609d76e1ae327_42a0208bd@natae.notmuch \
--to=felipe.contreras@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.