From: John Fastabend <john.fastabend@gmail.com>
To: Martynas Pumputis <m@lambda.lt>, bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, m@lambda.lt
Subject: RE: [PATCH bpf 1/2] libbpf: fix removal of inner map in bpf_object__create_map
Date: Thu, 15 Jul 2021 20:09:42 -0700 [thread overview]
Message-ID: <60f0f8764bb9c_2a5720890@john-XPS-13-9370.notmuch> (raw)
In-Reply-To: <20210714165440.472566-2-m@lambda.lt>
Martynas Pumputis wrote:
> If creating an outer map of a BTF-defined map-in-map fails (via
> bpf_object__create_map()), then the previously created its inner map
> won't be destroyed.
>
> Fix this by ensuring that the destroy routines are not bypassed in the
> case of a failure.
>
> Fixes: 646f02ffdd49c ("libbpf: Add BTF-defined map-in-map support")
> Reported-by: Andrii Nakryiko <andrii@kernel.org>
> Signed-off-by: Martynas Pumputis <m@lambda.lt>
> ---
LGTM.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2021-07-16 3:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 16:54 [PATCH bpf 0/2] libbpf: fix inner map removal in bpf_object__create_map Martynas Pumputis
2021-07-14 16:54 ` [PATCH bpf 1/2] libbpf: fix removal of inner map " Martynas Pumputis
2021-07-15 0:30 ` John Fastabend
2021-07-15 10:06 ` Martynas Pumputis
2021-07-15 19:59 ` John Fastabend
2021-07-16 3:06 ` John Fastabend
2021-07-16 3:09 ` John Fastabend [this message]
2021-07-16 5:27 ` Andrii Nakryiko
2021-07-16 15:24 ` Martynas Pumputis
2021-07-14 16:54 ` [PATCH bpf 2/2] selftests/bpf: check inner map deletion Martynas Pumputis
2021-07-16 3:11 ` John Fastabend
2021-07-16 5:35 ` Andrii Nakryiko
2021-07-16 15:09 ` Martynas Pumputis
2021-07-16 18:24 ` Andrii Nakryiko
2021-07-19 17:38 [PATCH v2 bpf 0/2] libbpf: fix inner map removal in bpf_object__create_map Martynas Pumputis
2021-07-19 17:38 ` [PATCH bpf 1/2] libbpf: fix removal of inner map " Martynas Pumputis
2021-07-19 22:58 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60f0f8764bb9c_2a5720890@john-XPS-13-9370.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=m@lambda.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.