Re: [PATCH] mmc: cqhci: Be more verbose in error irq handler

From: Adrian Hunter <adrian.hunter@intel.com>
To: "Kornel Dulęba" <korneld@chromium.org>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ritesh Harjani <riteshh@codeaurora.org>,
	Asutosh Das <quic_asutoshd@quicinc.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Radoslaw Biernacki <biernacki@google.com>,
	Guenter Roeck <groeck@chromium.org>,
	Gwendal Grignou <gwendal@chromium.org>,
	upstream@semihalf.com
Subject: Re: [PATCH] mmc: cqhci: Be more verbose in error irq handler
Date: Fri, 20 Oct 2023 10:40:52 +0300	[thread overview]
Message-ID: <613c51f0-c32e-4de5-9627-525d92fb06ed@intel.com> (raw)
In-Reply-To: <20231016095610.1095084-1-korneld@chromium.org>

On 16/10/23 12:56, Kornel Dulęba wrote:
> There are several reasons for controller to generate an error interrupt.
> They include controller<->card timeout, and CRC mismatch error.
> Right now we only get one line in the logs stating that CQE recovery was
> triggered, but with no information about what caused it.
> To figure out what happened be more verbose and dump the registers from
> irq error handler logic.
> This matches the behaviour of the software timeout logic, see
> cqhci_timeout.
> 
> Signed-off-by: Kornel Dulęba <korneld@chromium.org>
> ---
>  drivers/mmc/host/cqhci-core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c
> index b3d7d6d8d654..33abb4bd53b5 100644
> --- a/drivers/mmc/host/cqhci-core.c
> +++ b/drivers/mmc/host/cqhci-core.c
> @@ -700,8 +700,9 @@ static void cqhci_error_irq(struct mmc_host *mmc, u32 status, int cmd_error,
>  
>  	terri = cqhci_readl(cq_host, CQHCI_TERRI);
>  
> -	pr_debug("%s: cqhci: error IRQ status: 0x%08x cmd error %d data error %d TERRI: 0x%08x\n",
> -		 mmc_hostname(mmc), status, cmd_error, data_error, terri);
> +	pr_warn("%s: cqhci: error IRQ status: 0x%08x cmd error %d data error %d\n",
> +		 mmc_hostname(mmc), status, cmd_error, data_error);
> +	cqhci_dumpregs(cq_host);

For debugging, isn't dynamic debug seems more appropriate?

>  
>  	/* Forget about errors when recovery has already been triggered */
>  	if (cq_host->recovery_halt)