Re: [PATCH] QCA9984 VHT160 support

From: Sebastian Gottschall <s.gottschall@dd-wrt.com>
To: "Valo, Kalle" <kvalo@qca.qualcomm.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] QCA9984 VHT160 support
Date: Tue, 18 Oct 2016 11:16:49 +0200	[thread overview]
Message-ID: <615775b0-0a78-e573-fff5-77a0001f5553@dd-wrt.com> (raw)
In-Reply-To: <1be11c35-2a7d-4f08-4e1c-23548d6f8efc@dd-wrt.com>

i've seen you added a new firmware for 9984. is there anything you can 
tell about already?

Am 18.10.2016 um 10:20 schrieb Sebastian Gottschall:
> Am 14.10.2016 um 12:14 schrieb Valo, Kalle:
>> Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
>>
>>> This patch adds full VHT160 support for QCA9984 chipsets
>>> Tested on Netgear R7800. 80+80 is possible, but disabled so far since
>>> it seems to contain glitches like missing vht station flags (this may
>>> be firmware or mac80211 related)
>> So how did you disable 80+80 exactly? I can't find it and I would like
>> to add a comment to the code so that it's easy to enable it later (once
>> it's working).
>
>
> IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ  =vht160 only
> IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160_80PLUS80MHZ = vht160 and 80+80 
> support
>
> +    if ((ar->vht_cap_info & IEEE80211_VHT_CAP_SHORT_GI_160) &&
> +        !(ar->vht_cap_info & 
> IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160_80PLUS80MHZ))
> +        vht_cap.cap |= IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ;
> +
>
> so if the firmware itself doesnt contain the correct vht flags but 
> just short_gi_160 flag. i assume it supports vht160 and set the vht160 
> only flag.
> newer firmwares on codeaurora contain the correct flags. so this code 
> here gets avoided. unfortunatly the newer i found is also not stable 
> and crashes often.
> you can also enable 80+80 support with the current firmware.but all 
> station ht and vht flags seem to be empty then in vht160 mode too. so 
> it might be a firmware issue still with 80+80 or mac80211.
> i did not debug that much. but vht160 works. i also tested it now with 
> a 88w6964 marvell client in vht160 which worked too
>
>

-- 
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz:  Berliner Ring 101, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall@dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k