From: Stephen Smalley <sds@tycho.nsa.gov>
To: Ondrej Mosnacek <omosnace@redhat.com>, selinux@vger.kernel.org
Cc: selinux@tycho.nsa.gov, Daniel Jurgens <danielj@mellanox.com>
Subject: Re: [PATCH] libsepol: fix endianity in ibpkey range checks
Date: Wed, 17 Oct 2018 11:31:55 -0400 [thread overview]
Message-ID: <61a96080-4427-bb24-9cdd-ef52a181f665@tycho.nsa.gov> (raw)
In-Reply-To: <20181017144659.10960-1-omosnace@redhat.com>
On 10/17/2018 10:46 AM, Ondrej Mosnacek wrote:
> We need to convert from little-endian before dong range checks on the
> ibpkey port numbers, otherwise we would be checking a wrong value.
>
> Fixes: 9fbb3112769a ("libsepol: Add ibpkey ocontext handling")
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> libsepol/src/policydb.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/libsepol/src/policydb.c b/libsepol/src/policydb.c
> index a6d76ca3..dc201e2f 100644
> --- a/libsepol/src/policydb.c
> +++ b/libsepol/src/policydb.c
> @@ -2830,15 +2830,21 @@ static int ocontext_read_selinux(struct policydb_compat_info *info,
> break;
> case OCON_IBPKEY:
> rc = next_entry(buf, fp, sizeof(uint32_t) * 4);
> - if (rc < 0 || buf[2] > 0xffff || buf[3] > 0xffff)
> + if (rc < 0)
> return -1;
>
> + c->u.ibpkey.low_pkey = le32_to_cpu(buf[2]);
> + c->u.ibpkey.high_pkey = le32_to_cpu(buf[3]);
> +
> + if (c->u.ibpkey.low_pkey > 0xffff ||
> + c->u.ibpkey.high_pkey > 0xffff)
> + return -1;
> +
> + /* we want c->u.ibpkey.subnet_prefix in network
> + * (big-endian) order, just memcpy it */
> memcpy(&c->u.ibpkey.subnet_prefix, buf,
> sizeof(c->u.ibpkey.subnet_prefix)); >
> - c->u.ibpkey.low_pkey = le32_to_cpu(buf[2]);
> - c->u.ibpkey.high_pkey = le32_to_cpu(buf[3]);
> -
> if (context_read_and_validate
> (&c->context[0], p, fp))
> return -1;
>
next prev parent reply other threads:[~2018-10-17 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 14:46 [PATCH] libsepol: fix endianity in ibpkey range checks Ondrej Mosnacek
2018-10-17 15:04 ` William Roberts
2018-10-17 15:31 ` Stephen Smalley [this message]
2018-10-17 15:34 ` William Roberts
2018-10-17 16:06 ` William Roberts
2018-10-17 21:18 ` Paul Moore
2018-10-17 21:22 ` Stephen Smalley
2018-10-17 22:05 ` William Roberts
2018-10-18 7:20 ` Ondrej Mosnacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61a96080-4427-bb24-9cdd-ef52a181f665@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=danielj@mellanox.com \
--cc=omosnace@redhat.com \
--cc=selinux@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.