From: Jaroslav Kysela <perex@perex.cz>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 0/4] ALSA: Defer async signal handling
Date: Mon, 1 Aug 2022 10:08:24 +0200 [thread overview]
Message-ID: <61eda30e-6f2d-d3b1-7f87-43a25fb6ca91@perex.cz> (raw)
In-Reply-To: <20220728125945.29533-1-tiwai@suse.de>
On 28. 07. 22 14:59, Takashi Iwai wrote:
> Hi,
>
> this is a revised patch series for another attempt to address the
> potential deadlocks via kill_fasync() calls that have been reported by
> syzbot for long time. Only a missing linux/fs.h inclusion was added
> from v1 series[1].
>
> Instead of the previous series to drop the async handler[2], this
> tries to defer the kill_fasync() call. A few new common helpers are
> introduced at first, then the actual usages are replaced in the
> following patches.
>
> The patches passed the quick tests with alsa-lib test cases.
Thank you for your work. The code looks good (I would only move
schedule_work() call outside the spin lock context - commented in the patch
thread).
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
prev parent reply other threads:[~2022-08-01 8:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 12:59 [PATCH v2 0/4] ALSA: Defer async signal handling Takashi Iwai
2022-07-28 12:59 ` [PATCH v2 1/4] ALSA: core: Add async signal helpers Takashi Iwai
2022-08-01 8:05 ` Jaroslav Kysela
2022-08-01 10:13 ` Takashi Iwai
2022-08-01 10:43 ` Jaroslav Kysela
2022-08-01 10:48 ` Takashi Iwai
2022-07-28 12:59 ` [PATCH v2 2/4] ALSA: timer: Use deferred fasync helper Takashi Iwai
2022-07-28 12:59 ` [PATCH v2 3/4] ALSA: pcm: " Takashi Iwai
2022-07-28 12:59 ` [PATCH v2 4/4] ALSA: control: " Takashi Iwai
2022-08-01 8:08 ` Jaroslav Kysela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61eda30e-6f2d-d3b1-7f87-43a25fb6ca91@perex.cz \
--to=perex@perex.cz \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.