Re: [PATCH 0/6] drm: debug logging improvements

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Jani Nikula <jani.nikula@intel.com>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 0/6] drm: debug logging improvements
Date: Fri, 5 Apr 2024 10:55:08 +0200	[thread overview]
Message-ID: <62365cd0-fadf-47da-b8bf-d33e11f6dec7@suse.de> (raw)
In-Reply-To: <cover.1709843865.git.jani.nikula@intel.com>

Hi,

with your Oops on [5/6] fixed and my comment on [1/6] considered:

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Best regards
Thomas


Am 07.03.24 um 21:39 schrieb Jani Nikula:
> Switch a handful of places over to drm device based logging and WARNs,
> unify connector and crtc logging, etc.
>
> Jani Nikula (6):
>    drm/modes: add drm_mode_print() to dump mode in drm_printer
>    drm/probe-helper: switch to drm device based logging
>    drm/modes: switch drm_mode_prune_invalid() to use struct drm_printer
>    drm/modes: switch to drm device based error logging
>    drm/sysfs: switch to drm device based logging
>    drm/client: switch to drm device based logging, and more
>
>   drivers/gpu/drm/drm_client_modeset.c | 129 +++++++++++++++------------
>   drivers/gpu/drm/drm_modes.c          |  51 +++++++----
>   drivers/gpu/drm/drm_probe_helper.c   |  41 ++++-----
>   drivers/gpu/drm/drm_sysfs.c          |  21 +++--
>   include/drm/drm_modes.h              |   2 +
>   5 files changed, 137 insertions(+), 107 deletions(-)
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)