From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Christian Brauner <brauner@kernel.org>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"david@fromorbit.com" <david@fromorbit.com>,
"djwong@kernel.org" <djwong@kernel.org>,
"willy@infradead.org" <willy@infradead.org>,
"jlayton@kernel.org" <jlayton@kernel.org>
Subject: Re: [PATCH v5 4/4] ceph: Remove S_ISGID clear code in ceph_finish_async_create
Date: Thu, 21 Apr 2022 08:28:12 +0000 [thread overview]
Message-ID: <626123F9.8070004@fujitsu.com> (raw)
In-Reply-To: <20220421081852.rrmj2log3fln22lp@wittgenstein>
on 2022/4/21 16:18, Christian Brauner wrote:
> On Thu, Apr 21, 2022 at 03:54:18PM +0800, Yang Xu wrote:
>> Since vfs has stripped S_ISGID in the previous patch, the calltrace
>> as below:
>>
>> vfs: lookup_open
>> ...
>> if (open_flag& O_CREAT) {
>> if (open_flag& O_EXCL)
>> open_flag&= ~O_TRUNC;
>> mode = prepare_mode(mnt_userns, dir->d_inode, mode);
>> ...
>> dir_inode->i_op->atomic_open
>>
>> ceph: ceph_atomic_open
>> ...
>> if (flags& O_CREAT)
>> ceph_finish_async_create
>>
>> We have stripped sgid in prepare_mode, so remove this useless clear
>> code directly.
>
> I'd replace this with:
>
> "Previous patches moved sgid stripping exclusively into the vfs. So
> manual sgid stripping by the filesystem isn't needed anymore."
Looks more clear, so should I drop the above calltrace?
>
>>
>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>> ---
>
> Reviewed-by: Christian Brauner (Microsoft)<brauner@kernel.org>
next prev parent reply other threads:[~2022-04-21 8:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 7:54 [PATCH v5 1/4] fs: move sgid strip operation from inode_init_owner into inode_sgid_strip Yang Xu
2022-04-21 7:54 ` [PATCH v5 2/4] fs: Add missing umask strip in vfs_tmpfile Yang Xu
2022-04-21 7:24 ` Christian Brauner
2022-04-21 7:54 ` [PATCH v5 3/4] fs: strip file's S_ISGID mode on vfs instead of on underlying filesystem Yang Xu
2022-04-21 8:35 ` Christian Brauner
2022-04-22 6:03 ` xuyang2018.jy
2022-04-22 9:47 ` Christian Brauner
2022-04-22 10:13 ` xuyang2018.jy
2022-04-22 10:49 ` Christian Brauner
2022-04-21 7:54 ` [PATCH v5 4/4] ceph: Remove S_ISGID clear code in ceph_finish_async_create Yang Xu
2022-04-21 8:18 ` Christian Brauner
2022-04-21 8:28 ` xuyang2018.jy [this message]
2022-04-21 8:36 ` Christian Brauner
2022-04-21 8:33 ` Xiubo Li
2022-04-21 8:01 ` [PATCH v5 1/4] fs: move sgid strip operation from inode_init_owner into inode_sgid_strip Christian Brauner
2022-04-21 8:19 ` xuyang2018.jy
2022-04-22 6:53 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=626123F9.8070004@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.