Re: [PATCH v1 1/3] arm64: lib: Import latest version of Arm Optimized Routines' strcmp

From: Robin Murphy <robin.murphy@arm.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>,
	Joey Gouly <joey.gouly@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, nd@arm.com,
	catalin.marinas@arm.com, mark.rutland@arm.com, will@kernel.org
Subject: Re: [PATCH v1 1/3] arm64: lib: Import latest version of Arm Optimized Routines' strcmp
Date: Wed, 16 Feb 2022 18:36:12 +0000	[thread overview]
Message-ID: <626c6da4-547e-aa3e-3968-907e69e061d0@arm.com> (raw)
In-Reply-To: <Yg0p65cBPydbzepO@shell.armlinux.org.uk>

On 2022-02-16 16:44, Russell King (Oracle) wrote:
> On Tue, Feb 15, 2022 at 05:07:21PM +0000, Joey Gouly wrote:
>> Import the latest version of the Arm Optimized Routines strcmp function based
>> on the upstream code of string/aarch64/strcmp.S at commit 189dfefe37d5 from:
>>    https://github.com/ARM-software/optimized-routines
>>
>> This latest version includes MTE support.
>>
>> Signed-off-by: Joey Gouly <joey.gouly@arm.com>
>> Cc: Robin Murphy <robin.murphy@arm.com>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>> Cc: Will Deacon <will@kernel.org>
>> ---
>>   arch/arm64/lib/strcmp.S | 238 +++++++++++++++++++++-------------------
>>   1 file changed, 126 insertions(+), 112 deletions(-)
>>
>> diff --git a/arch/arm64/lib/strcmp.S b/arch/arm64/lib/strcmp.S
>> index 83bcad72ec97..758de77afd2f 100644
>> --- a/arch/arm64/lib/strcmp.S
>> +++ b/arch/arm64/lib/strcmp.S
>> @@ -1,9 +1,9 @@
>>   /* SPDX-License-Identifier: GPL-2.0-only */
> 
> Looking at the LICENSE file in the above repository, it appears that
> this code is licensed as "MIT OR Apache-2.0 WITH LLVM-exception".
> Shouldn't the SPDX line be updated to reflect the origin license of
> this code?

This is noted in the commits which first imported implementations from 
Arm Optimized Routines (020b199bc70d and earlier):

  "Note that for simplicity Arm have chosen to contribute this code
   to Linux under GPLv2 rather than the original MIT license."

Apologies for the confusion - I should have mentioned that to Joey 
beforehand, if I hadn't completely forgotten about it. I think it's just 
been implicit that we'd continue to follow the same approach going forward.

Thanks,
Robin.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel