Re: [PATCH v7 05/14] NFSD: Trace stateids returned via DELEGRETURN

From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Cc: neilb@suse.de
Subject: Re: [PATCH v7 05/14] NFSD: Trace stateids returned via DELEGRETURN
Date: Mon, 31 Oct 2022 12:33:12 -0400	[thread overview]
Message-ID: <62ae1f0ba19068e035aae30a0ac022e55c7374b0.camel@kernel.org> (raw)
In-Reply-To: <166696842358.106044.5702462087113424436.stgit@klimt.1015granger.net>

On Fri, 2022-10-28 at 10:47 -0400, Chuck Lever wrote:
> Handing out a delegation stateid is recorded with the
> nfsd_deleg_read tracepoint, but there isn't a matching tracepoint
> for recording when the stateid is returned.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  fs/nfsd/nfs4state.c |    1 +
>  fs/nfsd/trace.h     |    1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index c829b828b6fd..93cfae7cd391 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -6901,6 +6901,7 @@ nfsd4_delegreturn(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
>  	if (status)
>  		goto put_stateid;
>  
> +	trace_nfsd_deleg_return(stateid);
>  	wake_up_var(d_inode(cstate->current_fh.fh_dentry));
>  	destroy_delegation(dp);
>  put_stateid:
> diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h
> index b065a4b1e0dc..477c2b035872 100644
> --- a/fs/nfsd/trace.h
> +++ b/fs/nfsd/trace.h
> @@ -601,6 +601,7 @@ DEFINE_STATEID_EVENT(layout_recall_release);
>  
>  DEFINE_STATEID_EVENT(open);
>  DEFINE_STATEID_EVENT(deleg_read);
> +DEFINE_STATEID_EVENT(deleg_return);
>  DEFINE_STATEID_EVENT(deleg_recall);
>  
>  DECLARE_EVENT_CLASS(nfsd_stateseqid_class,
> 
> 

Reviewed-by: Jeff Layton <jlayton@kernel.org>