From: "Anders Höckersten" <anders@hockersten.se>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Bagas Sanjaya" <bagasdotme@gmail.com>,
"Anders Höckersten via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] describe-doc: clarify default length of abbreviation
Date: Mon, 17 May 2021 07:51:28 +0200 [thread overview]
Message-ID: <6306f894-4fda-4412-9b1b-6fcd9eed8e77@www.fastmail.com> (raw)
In-Reply-To: <xmqqo8da6dk4.fsf@gitster.g>
On Sun, May 16, 2021, at 14:58, Junio C Hamano wrote:
> Anders Höckersten <anders@hockersten.se> writes:
>
> > The explanation was mostly copied from the 2.11.0 release notes,
> > but mentioning the birtday paradox is unnecessary. I suggest
> > changing this sentence to: "The length of the abbreviation scales
> > as the repository grows using the approximate number of objects in
> > the repository, and by default the minimum length is 7."
>
> Heh. In my priate review, I said that I very much liked the way the
> new description was phrased with "a bit of math around the birthday
> paradox". Now I know why I liked that phrasing---it turns out to be
> my own ;-)
>
> I don't mind with or without mention of the birthday math. Thanks
> for working on this.
Actually, changed my mind again. I like the phrasing and it's in the "examples" section so a bit of verbosity doesn't hurt. Will submit a new patch with the other changes mentioned + whitespace fixes momentarily.
/A
next prev parent reply other threads:[~2021-05-17 5:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 7:32 [PATCH] describe-doc: clarify default length of abbreviation Anders Höckersten via GitGitGadget
2021-05-16 11:34 ` Junio C Hamano
2021-05-16 12:00 ` Bagas Sanjaya
2021-05-16 12:47 ` Anders Höckersten
2021-05-16 12:58 ` Junio C Hamano
2021-05-17 5:51 ` Anders Höckersten [this message]
2021-05-16 18:51 ` Felipe Contreras
2021-05-16 19:00 ` Robert P. J. Day
2021-05-16 21:07 ` Felipe Contreras
2021-05-17 5:53 ` [PATCH v2] " Anders Höckersten via GitGitGadget
2021-05-17 16:44 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6306f894-4fda-4412-9b1b-6fcd9eed8e77@www.fastmail.com \
--to=anders@hockersten.se \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.