Re: [RFC v3 13/19] vfio-user: pci_user_realize PCI setup

From: John Johnson <john.g.johnson@oracle.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [RFC v3 13/19] vfio-user: pci_user_realize PCI setup
Date: Tue, 7 Dec 2021 07:50:35 +0000	[thread overview]
Message-ID: <63C9EBEB-204A-4084-95C5-A8B907446E7E@oracle.com> (raw)
In-Reply-To: <20211119154230.0a06ea21.alex.williamson@redhat.com>


> On Nov 19, 2021, at 2:42 PM, Alex Williamson <alex.williamson@redhat.com> wrote:
> 
> On Mon,  8 Nov 2021 16:46:41 -0800
> John Johnson <john.g.johnson@oracle.com> wrote:
> 
>> PCI BARs read from remote device
>> PCI config reads/writes sent to remote server
>> 
>> Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
>> Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
>> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
>> ---
>> hw/vfio/pci.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 88 insertions(+), 1 deletion(-)
>> 
>> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
>> index d5f9987..f8729b2 100644
>> --- a/hw/vfio/pci.c
>> +++ b/hw/vfio/pci.c
>> @@ -3551,8 +3551,93 @@ static void vfio_user_pci_realize(PCIDevice *pdev, Error **errp)
>>         goto error;
>>     }
>> 
> 
> There's a LOT of duplication with the kernel realize function here.
> Thanks,
> 

	When I add more common properties, there will be even more
duplication, so I’ll add a vfio_realize_common() routine.

							JJ