From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next v2] thermal: armada: fix copy-paste error in armada_thermal_probe()
Date: Mon, 30 Jul 2018 06:25:36 +0000 [thread overview]
Message-ID: <63a86b2d-7f57-a3d6-1bad-9b1a998883f0@linaro.org> (raw)
In-Reply-To: <1532918717-46808-1-git-send-email-weiyongjun1@huawei.com>
On 30/07/2018 04:45, Wei Yongjun wrote:
> Fix the retrn value check which testing the wrong variable
s/retrn/return/
"which testing" is not correct.
I would suggest something like:
"The return value from devm_kzalloc() is not checked correctly. The
test is done against a wrong variable. Fix it."
> in armada_thermal_probe().
>
> Fixes: e72f03ef2543 ("thermal: armada: use the resource managed registration helper alternative")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> v1 - > v2: fix typo of patch subject
> ---
> drivers/thermal/armada_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
> index 8de4ba5..a269482 100644
> --- a/drivers/thermal/armada_thermal.c
> +++ b/drivers/thermal/armada_thermal.c
> @@ -610,7 +610,7 @@ static int armada_thermal_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> drvdata = devm_kzalloc(&pdev->dev, sizeof(*drvdata), GFP_KERNEL);
> - if (!priv)
> + if (!drvdata)
> return -ENOMEM;
>
> priv->dev = &pdev->dev;
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-07-30 6:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 2:45 [PATCH -next v2] thermal: armada: fix copy-paste error in armada_thermal_probe() Wei Yongjun
2018-07-30 6:25 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63a86b2d-7f57-a3d6-1bad-9b1a998883f0@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.