All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	linux-watchdog@vger.kernel.org,
	Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
	jorge@foundries.io, linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Guenter Roeck <groeck7@gmail.com>
Subject: Re: [PATCH] watchdog: qcom: Remove incorrect usage of QCOM_WDT_ENABLE_IRQ
Date: Tue, 26 Jan 2021 21:23:12 +0530	[thread overview]
Message-ID: <65015f8aa75efa6ead7dd7df45eb31d7@codeaurora.org> (raw)
In-Reply-To: <1c9d5e19-7ddd-345d-aa2d-b4fb48d9b4df@roeck-us.net>

On 2021-01-26 20:53, Guenter Roeck wrote:
> On 1/26/21 7:02 AM, Sai Prakash Ranjan wrote:
>> As per register documentation, QCOM_WDT_ENABLE_IRQ which is BIT(1)
>> of watchdog control register is wakeup interrupt enable bit and
>> not related to bark interrupt at all, BIT(0) is used for that.
>> So remove incorrect usage of this bit when supporting bark irq for
>> pre-timeout notification. Currently with this bit set and bark
>> interrupt specified, pre-timeout notification and/or watchdog
>> reset/bite does not occur.
>> 
>> Fixes: 36375491a439 ("watchdog: qcom: support pre-timeout when the 
>> bark irq is available")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> 
> Assuming that pretimeout _does_ work with this patch applied,
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 

Thanks Guenter. Yes I have patchset ready and tested [1] on 4
different SoCs on which pretimeout works with this patch and without
this, watchdog functionality would be broken on all those platforms
and possibly more(the ones I couldn't get access to) if we add bark
irq to the watchdog DT node.

[1] https://lore.kernel.org/patchwork/cover/1371270/

Thanks,
Sai

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation

  reply	other threads:[~2021-01-26 15:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 15:02 [PATCH] watchdog: qcom: Remove incorrect usage of QCOM_WDT_ENABLE_IRQ Sai Prakash Ranjan
2021-01-26 15:23 ` Guenter Roeck
2021-01-26 15:23   ` Guenter Roeck
2021-01-26 15:53   ` Sai Prakash Ranjan [this message]
2021-01-28  1:33 ` Stephen Boyd
2021-01-28  1:33   ` Stephen Boyd
2021-01-28 11:03   ` Sai Prakash Ranjan
2021-01-28  8:19 ` Jorge Ramirez-Ortiz, Foundries
2021-01-28  8:19   ` Jorge Ramirez-Ortiz, Foundries
2021-01-28 11:08   ` Sai Prakash Ranjan
2021-01-31 17:03     ` Jorge Ramirez-Ortiz, Foundries
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
2021-02-01  5:53 Sai Prakash Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65015f8aa75efa6ead7dd7df45eb31d7@codeaurora.org \
    --to=saiprakash.ranjan@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=groeck7@gmail.com \
    --cc=jorge.ramirez-ortiz@linaro.org \
    --cc=jorge@foundries.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=stable@vger.kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.