From: Guenter Roeck <linux@roeck-us.net>
To: Thierry Reding <thierry.reding@gmail.com>,
Arnd Bergmann <arnd@kernel.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Mark Brown <broonie@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Arnd Bergmann <arnd@arndb.de>, Dmitry Osipenko <digetx@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Zhang Qilong <zhangqilong3@huawei.com>,
Yang Yingliang <yangyingliang@huawei.com>,
linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: tegra20: fix build with CONFIG_PM_SLEEP=n
Date: Mon, 18 Oct 2021 07:28:12 -0700 [thread overview]
Message-ID: <65625987-9b8b-d0bc-5413-b8cd1f8ed14f@roeck-us.net> (raw)
In-Reply-To: <YW19Z4gF7UCECF1H@orome.fritz.box>
On 10/18/21 6:57 AM, Thierry Reding wrote:
> On Wed, Oct 13, 2021 at 04:45:23PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> There is another one of these warnings:
>>
>> drivers/spi/spi-tegra20-slink.c:1197:12: error: 'tegra_slink_runtime_resume' defined but not used [-Werror=unused-function]
>> 1197 | static int tegra_slink_runtime_resume(struct device *dev)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Give it the same treatment as the other functions in this file.
>>
>> Fixes: efafec27c565 ("spi: Fix tegra20 build with CONFIG_PM=n")
>> Fixes: 2bab94090b01 ("spi: tegra20-slink: Declare runtime suspend and resume functions conditionally")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/spi/spi-tegra20-slink.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Thierry Reding <treding@nvidia.com>
>
The problem has now been (re-)introduced into the mainline kernel
and causes various test build failures there.
Guenter
prev parent reply other threads:[~2021-10-18 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 14:45 [PATCH] spi: tegra20: fix build with CONFIG_PM_SLEEP=n Arnd Bergmann
2021-10-13 15:42 ` Guenter Roeck
2021-10-13 19:59 ` Mark Brown
2021-10-18 13:57 ` Thierry Reding
2021-10-18 14:28 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65625987-9b8b-d0bc-5413-b8cd1f8ed14f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=yangyingliang@huawei.com \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.