From: Dan Williams <dan.j.williams@intel.com>
To: Li Zhijian <lizhijian@fujitsu.com>, <nvdimm@lists.linux.dev>
Cc: <linux-cxl@vger.kernel.org>, Li Zhijian <lizhijian@fujitsu.com>,
"Dan Williams" <dan.j.williams@intel.com>
Subject: RE: [ndctl PATCH v2 2/2] test/cxl-region-sysfs.sh: Fix cxl-region-sysfs.sh: line 107: [: missing `]'
Date: Tue, 12 Dec 2023 14:46:09 -0800 [thread overview]
Message-ID: <6578e2b1609e9_a04c5294d3@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20231212074228.1261164-2-lizhijian@fujitsu.com>
Li Zhijian wrote:
> A space is missing before ']'
>
> Acked-by: Dan Williams <dan.j.williams@intel.com>
You added my Ack without addressing the feedback.
"Commentary on the impact of the change is always welcome."
Please include a sentence on how this triggered for you and some
analysis of the why it has not triggered previously. Otherwise "A space
is missing before ']'" does not add any information that can not be
determined by reading the patch.
A useful changelog for this would be something like:
Currently the cxl-region-sysfs.sh test runs to completion and passes,
but with syntax errors in the log. It turns out that because the test is
checking for a positive condition as a failure, that also happens to
mask the syntax errors. Fix the syntax and note that this also happens
to unblock a test case that was being hidden by this error.
next prev parent reply other threads:[~2023-12-12 22:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 7:42 [ndctl PATCH v2 1/2] test/cxl-region-sysfs.sh: use '[[ ]]' command to evaluate operands as arithmetic expressions Li Zhijian
2023-12-12 7:42 ` [ndctl PATCH v2 2/2] test/cxl-region-sysfs.sh: Fix cxl-region-sysfs.sh: line 107: [: missing `]' Li Zhijian
2023-12-12 20:54 ` Alison Schofield
2023-12-13 8:00 ` Zhijian Li (Fujitsu)
2023-12-12 22:46 ` Dan Williams [this message]
2023-12-13 7:50 ` Zhijian Li (Fujitsu)
2023-12-12 20:51 ` [ndctl PATCH v2 1/2] test/cxl-region-sysfs.sh: use '[[ ]]' command to evaluate operands as arithmetic expressions Alison Schofield
2023-12-13 8:02 ` Zhijian Li (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6578e2b1609e9_a04c5294d3@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.