From: Ira Weiny <ira.weiny@intel.com>
To: Ira Weiny <ira.weiny@intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>, <nvdimm@lists.linux.dev>
Subject: Re: [PATCH 2/3] nvdimm/dimm_devs: fix kernel-doc for function params
Date: Thu, 21 Dec 2023 14:34:14 -0800 [thread overview]
Message-ID: <6584bd663bd30_576052949c@iweiny-mobl.notmuch> (raw)
In-Reply-To: <6584bc064ea54_5580229435@iweiny-mobl.notmuch>
Ira Weiny wrote:
> Randy Dunlap wrote:
[snip]
> > diff -- a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
> > --- a/drivers/nvdimm/dimm_devs.c
> > +++ b/drivers/nvdimm/dimm_devs.c
> > @@ -53,7 +53,10 @@ static int validate_dimm(struct nvdimm_d
> >
> > /**
> > * nvdimm_init_nsarea - determine the geometry of a dimm's namespace area
> > - * @nvdimm: dimm to initialize
> > + * @ndd: dimm to initialize
> > + *
> > + * Returns: %0 if the area is already valid, -errno on error,
>
> This is good...
>
> > ...otherwise an
> > + * ND_CMD_* status code.
>
> I don't see where any of the ->ndctl() calls return an ND_CMD_* status
> code. What am I missing?
If you agree that this should be dropped I can clean it up as I'm trying
to prep the nvdimm tree now and was hoping to take this series.
Ira
>
> The rest looks good,
> Ira
next prev parent reply other threads:[~2023-12-21 22:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 21:05 [PATCH 1/3] nvdimm/btt: fix btt_blk_cleanup() kernel-doc Randy Dunlap
2023-12-07 21:05 ` [PATCH 2/3] nvdimm/dimm_devs: fix kernel-doc for function params Randy Dunlap
2023-12-21 22:28 ` Ira Weiny
2023-12-21 22:34 ` Ira Weiny [this message]
2023-12-21 23:34 ` Randy Dunlap
2023-12-07 21:05 ` [PATCH 3/3] nvdimm/namespace: " Randy Dunlap
2023-12-21 22:32 ` Ira Weiny
2023-12-21 23:26 ` Randy Dunlap
2023-12-21 23:29 ` Ira Weiny
2023-12-21 22:14 ` [PATCH 1/3] nvdimm/btt: fix btt_blk_cleanup() kernel-doc Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6584bd663bd30_576052949c@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=rdunlap@infradead.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.