From: Randy Dunlap <rdunlap@infradead.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>,
huzhi001@208suo.com, Petr Mladek <pmladek@suse.com>
Cc: tglx@linutronix.de, adobriyan@gmail.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] proc: Fix four errors in kmsg.c
Date: Sun, 16 Jul 2023 23:08:31 -0700 [thread overview]
Message-ID: <658bfc14-3819-8cf2-6e08-a9794c72f4c8@infradead.org> (raw)
In-Reply-To: <20230717060500.GB57770@google.com>
On 7/16/23 23:05, Sergey Senozhatsky wrote:
> On (23/07/14 10:22), Petr Mladek wrote:
>> On Fri 2023-07-14 14:57:59, huzhi001@208suo.com wrote:
>>> The following checkpatch errors are removed:
>>> ERROR: "foo * bar" should be "foo *bar"
>>> ERROR: "foo * bar" should be "foo *bar"
>>> ERROR: "foo * bar" should be "foo *bar"
>>> ERROR: "foo * bar" should be "foo *bar"
>>
>> Please, do not do fix these cosmetic issues reported by checkpatch.pl.
>> It is not worth the effort. In fact, it is contra productive.
>> It complicates the git history, backports.
>
> Absolutely agree with Petr.
>
> As a side note, I wonder if checkpatch can deprecate that -f option?
Either that or document in very strong language that it should only be used
in very special circumstances, usually by the file owner or maintainer.
--
~Randy
prev parent reply other threads:[~2023-07-17 6:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_053A1A860EFB7AAD92B2409B9D5AE06AB507@qq.com>
2023-07-14 6:57 ` [PATCH] proc: Fix four errors in kmsg.c huzhi001
2023-07-14 8:22 ` Petr Mladek
2023-07-14 8:31 ` Petr Mladek
2023-07-17 6:05 ` Sergey Senozhatsky
2023-07-17 6:08 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658bfc14-3819-8cf2-6e08-a9794c72f4c8@infradead.org \
--to=rdunlap@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=huzhi001@208suo.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.