All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: Peter Robinson <pbrobinson@gmail.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	"Dave Jiang" <dave.jiang@intel.com>,
	Ira Weiny <ira.weiny@intel.com>, <nvdimm@lists.linux.dev>
Cc: Peter Robinson <pbrobinson@gmail.com>
Subject: Re: [PATCH] libnvdimm: Fix ACPI_NFIT in BLK_DEV_PMEM help
Date: Mon, 12 Feb 2024 09:00:58 -0800	[thread overview]
Message-ID: <65ca4eca209b0_8387e294c3@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20240212123716.795996-1-pbrobinson@gmail.com>

Peter Robinson wrote:
> The ACPI_NFIT config option is described incorrectly as the
> inverse NFIT_ACPI, which doesn't exist, so update the help
> to the actual config option.
> 
> Fixes: 18da2c9ee41a0 ("libnvdimm, pmem: move pmem to drivers/nvdimm/")

I don't think this warrants a fixes tag as this commit has been around
since 2015 and has not bothered anyone.  But the change is valid for the
next merge window.

> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  drivers/nvdimm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvdimm/Kconfig b/drivers/nvdimm/Kconfig
> index 77b06d54cc62e..fde3e17c836c8 100644
> --- a/drivers/nvdimm/Kconfig
> +++ b/drivers/nvdimm/Kconfig
> @@ -24,7 +24,7 @@ config BLK_DEV_PMEM
>  	select ND_PFN if NVDIMM_PFN
>  	help
>  	  Memory ranges for PMEM are described by either an NFIT
> -	  (NVDIMM Firmware Interface Table, see CONFIG_NFIT_ACPI), a
> +	  (NVDIMM Firmware Interface Table, see CONFIG_ACPI_NFIT), a
>  	  non-standard OEM-specific E820 memory type (type-12, see
>  	  CONFIG_X86_PMEM_LEGACY), or it is manually specified by the
>  	  'memmap=nn[KMG]!ss[KMG]' kernel command line (see
> -- 
> 2.43.0
> 



  parent reply	other threads:[~2024-02-12 17:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 12:37 [PATCH] libnvdimm: Fix ACPI_NFIT in BLK_DEV_PMEM help Peter Robinson
2024-02-12 16:42 ` Dave Jiang
2024-02-12 17:00 ` Ira Weiny [this message]
2024-02-12 18:10   ` Peter Robinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65ca4eca209b0_8387e294c3@iweiny-mobl.notmuch \
    --to=ira.weiny@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=pbrobinson@gmail.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.