From: Stefan Berger <stefanb@linux.ibm.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: jeyu@kernel.org, keyrings@vger.kernel.org, dhowells@redhat.com,
dwmw2@infradead.org, zohar@linux.ibm.com, nayna@linux.ibm.com,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/2] Add support for ECDSA-signed kernel modules
Date: Thu, 10 Jun 2021 07:50:01 -0400 [thread overview]
Message-ID: <66d4a4be-c01c-7f33-9a7f-20cfdb5dcf96@linux.ibm.com> (raw)
In-Reply-To: <20210610090323.f7b47xqxbkwnm5cx@kernel.org>
On 6/10/21 5:03 AM, Jarkko Sakkinen wrote:
> On Wed, Jun 09, 2021 at 09:58:29AM -0400, Stefan Berger wrote:
>> On 6/9/21 8:44 AM, Jarkko Sakkinen wrote:
>>> On Thu, Jun 03, 2021 at 08:32:59AM -0400, Stefan Berger wrote:
>>>> On 6/3/21 2:47 AM, Jarkko Sakkinen wrote:
>>>>>> --
>>>>>> 2.29.2
>>>>>>
>>>>>>
>>>>> Please instead send a fix.
>>>> We have a Fixes tag in 1/2, so we want this to propagate to older kernels
>>>> and need the fix in 1/2 for that reason.
>>>>
>>>> Stefan
>>> So please do an additional fix and send it.
>> 1/2 is supposed to propagate to older kernels and needs to change as posted
>> here in v5 (assuming that this does indeed fix what the build bot was
>> complaining about). 2/2 also changes. A fix on top of v4 would fix 2/2 but
>> won't apply cleanly to 1/2 as cannot easily propagate to older kernels. Is
>> that what we want? Why can you not remove v4 from your queue and replace it
>> with v5?
>>
>> Stefan
> What you can do is to send fix or fixes with appropriate fixes tags and
> I can then squash them for appropriate patches. That's less work for me.
Once you squash a fix on top of existing 1/2 , existing 2/2 will not
apply anymore. I am not sure what to send you. I think it would take
less time to remove the existing 2 patches and replace them with v5.
Stefan
next prev parent reply other threads:[~2021-06-10 11:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 14:35 [PATCH v5 0/2] Add support for ECDSA-signed kernel modules Stefan Berger
2021-06-02 14:35 ` [PATCH v5 1/2] certs: Trigger creation of RSA module signing key if it's not an RSA key Stefan Berger
2021-06-02 14:35 ` [PATCH v5 2/2] certs: Add support for using elliptic curve keys for signing modules Stefan Berger
2021-06-03 6:47 ` [PATCH v5 0/2] Add support for ECDSA-signed kernel modules Jarkko Sakkinen
2021-06-03 12:32 ` Stefan Berger
2021-06-09 12:44 ` Jarkko Sakkinen
2021-06-09 13:58 ` Stefan Berger
2021-06-10 9:03 ` Jarkko Sakkinen
2021-06-10 11:50 ` Stefan Berger [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-01 10:52 Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66d4a4be-c01c-7f33-9a7f-20cfdb5dcf96@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=jarkko@kernel.org \
--cc=jeyu@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.