Re: [PATCH v7 1/6] drm/client: Export drm_client_dev_unregister()

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	tvrtko.ursulin@linux.intel.com, ville.syrjala@linux.intel.com,
	imre.deak@intel.com, tejas.upadhyay@intel.com,
	jouni.hogander@intel.com, javierm@redhat.com, airlied@gmail.com,
	daniel@ffwll.ch, lucas.demarchi@intel.com, ogabbay@kernel.org,
	thomas.hellstrom@linux.intel.com,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v7 1/6] drm/client: Export drm_client_dev_unregister()
Date: Mon, 8 Apr 2024 14:07:04 +0200	[thread overview]
Message-ID: <67100444-2ea0-42c2-a6ba-d1444ded5c3f@suse.de> (raw)
In-Reply-To: <ZeszikpTbZuYTav8@intel.com>

Hi

Am 08.03.24 um 16:49 schrieb Rodrigo Vivi:
> On Fri, Mar 01, 2024 at 02:42:54PM +0100, Thomas Zimmermann wrote:
>> Export drm_client_dev_unregister() for use by the i915 driver. The
>> driver does not use drm_dev_unregister(),
> Perhaps we should make i915 to call for the drm_dev_unregister since it calls
> for drm_dev_register?

Not that I disagree, but this appears to be a separate change unrelated 
to fbdev support.

Best regards
Thomas

>
>> so it has to clean up the
>> in-kernel DRM clients by itself.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>>   drivers/gpu/drm/drm_client.c | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
>> index 9403b3f576f7b..3d4f8b77d0789 100644
>> --- a/drivers/gpu/drm/drm_client.c
>> +++ b/drivers/gpu/drm/drm_client.c
>> @@ -172,6 +172,18 @@ void drm_client_release(struct drm_client_dev *client)
>>   }
>>   EXPORT_SYMBOL(drm_client_release);
>>   
>> +/**
>> + * drm_client_dev_unregister - Unregister clients
>> + * @dev: DRM device
>> + *
>> + * This function releases all clients by calling each client's
>> + * &drm_client_funcs.unregister callback. The callback function
>> + * is responsibe for releaseing all resources including the client
>> + * itself.
>> + *
>> + * The helper drm_dev_unregister() calls this function. Drivers
>> + * that use it don't need to call this function themselves.
>> + */
>>   void drm_client_dev_unregister(struct drm_device *dev)
>>   {
>>   	struct drm_client_dev *client, *tmp;
>> @@ -191,6 +203,7 @@ void drm_client_dev_unregister(struct drm_device *dev)
>>   	}
>>   	mutex_unlock(&dev->clientlist_mutex);
>>   }
>> +EXPORT_SYMBOL(drm_client_dev_unregister);
>>   
>>   /**
>>    * drm_client_dev_hotplug - Send hotplug event to clients
>> -- 
>> 2.43.2
>>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)