From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11
Date: Thu, 24 Jun 2021 10:48:42 +0100 [thread overview]
Message-ID: <67246d0b-bc74-7b5b-23ae-a1895acea8bb@linux.intel.com> (raw)
In-Reply-To: <20210623072144.890147-1-tejaskumarx.surendrakumar.upadhyay@intel.com>
On 23/06/2021 08:21, Tejas Upadhyay wrote:
> EHL and JSL are also observing requirement for 80ns interval for
> CTX_TIMESTAMP thus extending it to GEN11.
If testing confirms this:
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
You only may need to change that INTEL_GEN to GRAPHICS_VER since I think
that's the new thing now.
Regards,
Tvrtko
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> ---
> drivers/gpu/drm/i915/gt/selftest_engine_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_engine_pm.c b/drivers/gpu/drm/i915/gt/selftest_engine_pm.c
> index 72cca3f0da21..d0afadf34649 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_engine_pm.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_engine_pm.c
> @@ -173,8 +173,8 @@ static int __live_engine_timestamps(struct intel_engine_cs *engine)
> d_ctx = trifilter(s_ctx);
>
> d_ctx *= engine->gt->clock_frequency;
> - if (IS_ICELAKE(engine->i915))
> - d_ring *= 12500000; /* Fixed 80ns for icl ctx timestamp? */
> + if (IS_GEN(engine->i915, 11))
> + d_ring *= 12500000; /* Fixed 80ns for GEN11 ctx timestamp? */
> else
> d_ring *= engine->gt->clock_frequency;
>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-06-24 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 7:21 [Intel-gfx] [PATCH] drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11 Tejas Upadhyay
2021-06-23 8:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-06-23 9:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-06-23 11:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest: Extend ctx_timestamp ICL workaround to GEN11 (rev2) Patchwork
2021-06-23 12:31 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-06-24 9:48 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67246d0b-bc74-7b5b-23ae-a1895acea8bb@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tejaskumarx.surendrakumar.upadhyay@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.