All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: Ruan Jinjie <ruanjinjie@huawei.com>, <linux-mm@kvack.org>,
	Vitaly Wool <vitaly.wool@konsulko.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -next v2] mm/z3fold: use helper function put_z3fold_locked() and put_z3fold_locked_list()
Date: Fri, 4 Aug 2023 10:24:48 +0800	[thread overview]
Message-ID: <674f87f8-a5b0-171a-0bb4-a8545699f2b6@huawei.com> (raw)
In-Reply-To: <20230803113824.886413-1-ruanjinjie@huawei.com>

On 2023/8/3 19:38, Ruan Jinjie wrote:
> This code is already duplicated six times, use helper function
> put_z3fold_locked() to release z3fold page instead of open code it
> to help improve code readability a bit. And add
> put_z3fold_locked_list() helper function to

It might be better to keep line at around 70-75 characters.

> be consistent with it. No functional change involved.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>

Thanks.


      reply	other threads:[~2023-08-04  2:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03 11:38 [PATCH -next v2] mm/z3fold: use helper function put_z3fold_locked() and put_z3fold_locked_list() Ruan Jinjie
2023-08-04  2:24 ` Miaohe Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=674f87f8-a5b0-171a-0bb4-a8545699f2b6@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=ruanjinjie@huawei.com \
    --cc=vitaly.wool@konsulko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.