From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Harry Wentland <harry.wentland@amd.com>,
sunpeng.li@amd.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits
Date: Wed, 10 Jan 2018 10:41:45 +0100 [thread overview]
Message-ID: <67851d94-b189-dc8e-b48f-2c3f8d92f50e@linux.intel.com> (raw)
In-Reply-To: <846a20f2-9453-0b10-614c-7df14c15a25b@amd.com>
Op 08-01-18 om 22:30 schreef Harry Wentland:
> On 2018-01-04 02:47 PM, sunpeng.li@amd.com wrote:
>> From: "Leo (Sunpeng) Li" <sunpeng.li@amd.com>
>>
>> During a non-blocking commit, it is possible to return before the
>> commit_tail work is queued (-ERESTARTSYS, for example).
>>
>> Since a reference on the crtc commit object is obtained for the pending
>> vblank event when preparing the commit, the above situation will leave
>> us with an extra reference.
>>
>> Therefore, if the commit_tail worker has not consumed the event at the
>> end of a commit, release it's reference.
>>
>> Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com>
> No expert on this but looks sane to me.
>
> Acked-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
Hey,
I've reverted the patch for now. I planned to apply it to the drm-misc-fixes branch with the
appropriate commits referenced, but it is causing crashes on the kms_flip testcase.
https://bugs.freedesktop.org/show_bug.cgi?id=104566
I'll investigate it some more then send out a fixed patch. :)
~Maarten
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-01-10 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 19:47 [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits sunpeng.li
2018-01-08 21:30 ` Harry Wentland
2018-01-09 18:13 ` Alex Deucher
2018-01-10 9:27 ` Daniel Vetter
2018-01-10 9:41 ` Maarten Lankhorst [this message]
2018-01-17 11:51 Maarten Lankhorst
2018-01-17 18:29 ` Sean Paul
2018-01-17 18:39 ` [Intel-gfx] " Maarten Lankhorst
2018-01-17 20:18 ` Sean Paul
2018-01-29 15:41 ` Leo Li
2018-01-30 10:28 ` Maarten Lankhorst
2018-01-31 19:57 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67851d94-b189-dc8e-b48f-2c3f8d92f50e@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.