From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Juergen Gross" <jgross@suse.com>,
"Igor Druzhinin" <igor.druzhinin@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 3/3] x86/ucode: Introduce ucode=allow-same for testing purposes
Date: Wed, 28 Oct 2020 09:35:02 +0100 [thread overview]
Message-ID: <67f2df64-68e2-23e6-172f-9824eb8f7e14@suse.com> (raw)
In-Reply-To: <20201026172519.17881-4-andrew.cooper3@citrix.com>
On 26.10.2020 18:25, Andrew Cooper wrote:
> Many CPUs will actually reload microcode when offered the same version as
> currently loaded. This allows for easy testing of the late microcode loading
> path.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
with one nit:
> @@ -2248,6 +2248,11 @@ precedence over `scan`.
> stop_machine context. In NMI handler, even NMIs are blocked, which is
> considered safer. The default value is `true`.
>
> +'allow-same' alters the default acceptance policy for new microcode to permit
> +trying to reload the same version. Many CPUs will actually reload microcode
> +of the same version, and this allows for easily testing of the late microcode
> +loading path.
Either "easy" or drop "of"?
Jan
next prev parent reply other threads:[~2020-10-28 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 17:25 [PATCH 0/3] x86/ucode: Fixes and improvements to ucode revision handling Andrew Cooper
2020-10-26 17:25 ` [PATCH 1/3] x86/ucode: Break out compare_revisions() from existing infrastructure Andrew Cooper
2020-10-28 8:21 ` Jan Beulich
2020-10-26 17:25 ` [PATCH 2/3] x86/ucode/intel: Fix handling of microcode revision Andrew Cooper
2020-10-28 8:32 ` Jan Beulich
2020-10-26 17:25 ` [PATCH 3/3] x86/ucode: Introduce ucode=allow-same for testing purposes Andrew Cooper
2020-10-28 8:35 ` Jan Beulich [this message]
2020-10-28 8:36 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67f2df64-68e2-23e6-172f-9824eb8f7e14@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=igor.druzhinin@citrix.com \
--cc=jgross@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.