Re: [PATCH v4 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible

From: Neil Armstrong <neil.armstrong@linaro.org>
To: Lee Jones <lee@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Satya Priya <quic_c_skakit@quicinc.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Andy Gross <agross@kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
	linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible
Date: Mon, 31 Oct 2022 16:35:38 +0100	[thread overview]
Message-ID: <6858acf3-eb90-41aa-b714-a2ceb6afe9db@linaro.org> (raw)
In-Reply-To: <Y1/qnCyav/S35mRo@google.com>

Hi,

On 31/10/2022 16:32, Lee Jones wrote:
> On Fri, 21 Oct 2022, Neil Armstrong wrote:
> 
>> The PM8018 compatible is always used with PM8921 fallback, so PM8018
>> compatible can be safely removed from device ID table
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> 
> Tags should appear chronologically.

Indeed, they were added by b4, I'll report this.

Thanks,
Neil

> 
> I've fixed this up and applied the patch, thanks.
> 
>> ---
>>   drivers/mfd/qcom-pm8xxx.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
>> index 2f2734ba5273..601106580e2e 100644
>> --- a/drivers/mfd/qcom-pm8xxx.c
>> +++ b/drivers/mfd/qcom-pm8xxx.c
>> @@ -497,7 +497,6 @@ static const struct pm_irq_data pm8821_data = {
>>   };
>>   
>>   static const struct of_device_id pm8xxx_id_table[] = {
>> -	{ .compatible = "qcom,pm8018", .data = &pm8xxx_data},
>>   	{ .compatible = "qcom,pm8058", .data = &pm8xxx_data},
>>   	{ .compatible = "qcom,pm8821", .data = &pm8821_data},
>>   	{ .compatible = "qcom,pm8921", .data = &pm8xxx_data},
>>
> 