From: Josef Bacik <josef@toxicpanda.com>
To: Naohiro Aota <naohiro.aota@wdc.com>,
linux-btrfs@vger.kernel.org, dsterba@suse.com
Cc: hare@suse.com, linux-fsdevel@vger.kernel.org,
Damien Le Moal <damien.lemoal@wdc.com>
Subject: Re: [PATCH v9 04/41] btrfs: Get zone information of zoned block devices
Date: Mon, 2 Nov 2020 11:53:35 -0500 [thread overview]
Message-ID: <69081702-5b34-1362-6e76-6769083a912c@toxicpanda.com> (raw)
In-Reply-To: <feca5ea7b6dc1a62eddbc00e01452b92523c8f36.1604065694.git.naohiro.aota@wdc.com>
On 10/30/20 9:51 AM, Naohiro Aota wrote:
> If a zoned block device is found, get its zone information (number of zones
> and zone size) using the new helper function btrfs_get_dev_zone_info(). To
> avoid costly run-time zone report commands to test the device zones type
> during block allocation, attach the seq_zones bitmap to the device
> structure to indicate if a zone is sequential or accept random writes. Also
> it attaches the empty_zones bitmap to indicate if a zone is empty or not.
>
> This patch also introduces the helper function btrfs_dev_is_sequential() to
> test if the zone storing a block is a sequential write required zone and
> btrfs_dev_is_empty_zone() to test if the zone is a empty zone.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
> Reviewed-by: Josef Bacik <josef@toxicpanda.com>
> ---
> fs/btrfs/Makefile | 1 +
> fs/btrfs/dev-replace.c | 5 ++
> fs/btrfs/super.c | 5 ++
> fs/btrfs/volumes.c | 19 ++++-
> fs/btrfs/volumes.h | 4 +
> fs/btrfs/zoned.c | 176 +++++++++++++++++++++++++++++++++++++++++
> fs/btrfs/zoned.h | 86 ++++++++++++++++++++
> 7 files changed, 294 insertions(+), 2 deletions(-)
> create mode 100644 fs/btrfs/zoned.c
> create mode 100644 fs/btrfs/zoned.h
>
> diff --git a/fs/btrfs/Makefile b/fs/btrfs/Makefile
> index e738f6206ea5..0497fdc37f90 100644
> --- a/fs/btrfs/Makefile
> +++ b/fs/btrfs/Makefile
> @@ -16,6 +16,7 @@ btrfs-y += super.o ctree.o extent-tree.o print-tree.o root-tree.o dir-item.o \
> btrfs-$(CONFIG_BTRFS_FS_POSIX_ACL) += acl.o
> btrfs-$(CONFIG_BTRFS_FS_CHECK_INTEGRITY) += check-integrity.o
> btrfs-$(CONFIG_BTRFS_FS_REF_VERIFY) += ref-verify.o
> +btrfs-$(CONFIG_BLK_DEV_ZONED) += zoned.o
>
> btrfs-$(CONFIG_BTRFS_FS_RUN_SANITY_TESTS) += tests/free-space-tests.o \
> tests/extent-buffer-tests.o tests/btrfs-tests.o \
> diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> index 20ce1970015f..6f6d77224c2b 100644
> --- a/fs/btrfs/dev-replace.c
> +++ b/fs/btrfs/dev-replace.c
> @@ -21,6 +21,7 @@
> #include "rcu-string.h"
> #include "dev-replace.h"
> #include "sysfs.h"
> +#include "zoned.h"
>
> /*
> * Device replace overview
> @@ -291,6 +292,10 @@ static int btrfs_init_dev_replace_tgtdev(struct btrfs_fs_info *fs_info,
> set_blocksize(device->bdev, BTRFS_BDEV_BLOCKSIZE);
> device->fs_devices = fs_info->fs_devices;
>
> + ret = btrfs_get_dev_zone_info(device);
> + if (ret)
> + goto error;
> +
> mutex_lock(&fs_info->fs_devices->device_list_mutex);
> list_add(&device->dev_list, &fs_info->fs_devices->devices);
> fs_info->fs_devices->num_devices++;
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index 8840a4fa81eb..ed55014fd1bd 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -2462,6 +2462,11 @@ static void __init btrfs_print_mod_info(void)
> #endif
> #ifdef CONFIG_BTRFS_FS_REF_VERIFY
> ", ref-verify=on"
> +#endif
> +#ifdef CONFIG_BLK_DEV_ZONED
> + ", zoned=yes"
> +#else
> + ", zoned=no"
> #endif
> ;
> pr_info("Btrfs loaded, crc32c=%s%s\n", crc32c_impl(), options);
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 58b9c419a2b6..e787bf89f761 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -31,6 +31,7 @@
> #include "space-info.h"
> #include "block-group.h"
> #include "discard.h"
> +#include "zoned.h"
>
> const struct btrfs_raid_attr btrfs_raid_array[BTRFS_NR_RAID_TYPES] = {
> [BTRFS_RAID_RAID10] = {
> @@ -374,6 +375,7 @@ void btrfs_free_device(struct btrfs_device *device)
> rcu_string_free(device->name);
> extent_io_tree_release(&device->alloc_state);
> bio_put(device->flush_bio);
> + btrfs_destroy_dev_zone_info(device);
> kfree(device);
> }
>
> @@ -667,6 +669,11 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
> clear_bit(BTRFS_DEV_STATE_IN_FS_METADATA, &device->dev_state);
> device->mode = flags;
>
> + /* Get zone type information of zoned block devices */
> + ret = btrfs_get_dev_zone_info(device);
> + if (ret != 0)
> + goto error_free_page;
> +
> fs_devices->open_devices++;
> if (test_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state) &&
> device->devid != BTRFS_DEV_REPLACE_DEVID) {
> @@ -1143,6 +1150,7 @@ static void btrfs_close_one_device(struct btrfs_device *device)
> device->bdev = NULL;
> }
> clear_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state);
> + btrfs_destroy_dev_zone_info(device);
>
> device->fs_info = NULL;
> atomic_set(&device->dev_stats_ccnt, 0);
> @@ -2543,6 +2551,14 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
> }
> rcu_assign_pointer(device->name, name);
>
> + device->fs_info = fs_info;
> + device->bdev = bdev;
> +
> + /* Get zone type information of zoned block devices */
> + ret = btrfs_get_dev_zone_info(device);
> + if (ret)
> + goto error_free_device;
> +
> trans = btrfs_start_transaction(root, 0);
> if (IS_ERR(trans)) {
> ret = PTR_ERR(trans);
> @@ -2559,8 +2575,6 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
> fs_info->sectorsize);
> device->disk_total_bytes = device->total_bytes;
> device->commit_total_bytes = device->total_bytes;
> - device->fs_info = fs_info;
> - device->bdev = bdev;
> set_bit(BTRFS_DEV_STATE_IN_FS_METADATA, &device->dev_state);
> clear_bit(BTRFS_DEV_STATE_REPLACE_TGT, &device->dev_state);
> device->mode = FMODE_EXCL;
> @@ -2707,6 +2721,7 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
> sb->s_flags |= SB_RDONLY;
> if (trans)
> btrfs_end_transaction(trans);
> + btrfs_destroy_dev_zone_info(device);
> error_free_device:
> btrfs_free_device(device);
> error:
> diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
> index bf27ac07d315..9c07b97a2260 100644
> --- a/fs/btrfs/volumes.h
> +++ b/fs/btrfs/volumes.h
> @@ -51,6 +51,8 @@ struct btrfs_io_geometry {
> #define BTRFS_DEV_STATE_REPLACE_TGT (3)
> #define BTRFS_DEV_STATE_FLUSH_SENT (4)
>
> +struct btrfs_zoned_device_info;
> +
> struct btrfs_device {
> struct list_head dev_list; /* device_list_mutex */
> struct list_head dev_alloc_list; /* chunk mutex */
> @@ -64,6 +66,8 @@ struct btrfs_device {
>
> struct block_device *bdev;
>
> + struct btrfs_zoned_device_info *zone_info;
> +
> /* the mode sent to blkdev_get */
> fmode_t mode;
>
> diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
> new file mode 100644
> index 000000000000..5657d654bc44
> --- /dev/null
> +++ b/fs/btrfs/zoned.c
> @@ -0,0 +1,176 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <linux/slab.h>
> +#include <linux/blkdev.h>
> +#include "ctree.h"
> +#include "volumes.h"
> +#include "zoned.h"
> +#include "rcu-string.h"
> +
> +/* Maximum number of zones to report per blkdev_report_zones() call */
> +#define BTRFS_REPORT_NR_ZONES 4096
> +
> +static int copy_zone_info_cb(struct blk_zone *zone, unsigned int idx,
> + void *data)
> +{
> + struct blk_zone *zones = data;
> +
> + memcpy(&zones[idx], zone, sizeof(*zone));
> +
> + return 0;
> +}
> +
> +static int btrfs_get_dev_zones(struct btrfs_device *device, u64 pos,
> + struct blk_zone *zones, unsigned int *nr_zones)
> +{
> + int ret;
> +
> + if (!*nr_zones)
> + return 0;
> +
> + ret = blkdev_report_zones(device->bdev, pos >> SECTOR_SHIFT, *nr_zones,
> + copy_zone_info_cb, zones);
> + if (ret < 0) {
> + btrfs_err_in_rcu(device->fs_info,
> + "get zone at %llu on %s failed %d", pos,
> + rcu_str_deref(device->name), ret);
> + return ret;
> + }
> + *nr_zones = ret;
> + if (!ret)
> + return -EIO;
> +
> + return 0;
> +}
> +
> +int btrfs_get_dev_zone_info(struct btrfs_device *device)
> +{
> + struct btrfs_zoned_device_info *zone_info = NULL;
> + struct block_device *bdev = device->bdev;
> + sector_t nr_sectors = bdev->bd_part->nr_sects;
> + sector_t sector = 0;
> + struct blk_zone *zones = NULL;
> + unsigned int i, nreported = 0, nr_zones;
> + unsigned int zone_sectors;
> + int ret;
> + char devstr[sizeof(device->fs_info->sb->s_id) +
> + sizeof(" (device )") - 1];
> +
> + if (!bdev_is_zoned(bdev))
> + return 0;
> +
> + if (device->zone_info)
> + return 0;
> +
> + zone_info = kzalloc(sizeof(*zone_info), GFP_KERNEL);
> + if (!zone_info)
> + return -ENOMEM;
> +
> + zone_sectors = bdev_zone_sectors(bdev);
> + ASSERT(is_power_of_2(zone_sectors));
> + zone_info->zone_size = (u64)zone_sectors << SECTOR_SHIFT;
> + zone_info->zone_size_shift = ilog2(zone_info->zone_size);
> + zone_info->nr_zones = nr_sectors >> ilog2(bdev_zone_sectors(bdev));
> + if (!IS_ALIGNED(nr_sectors, zone_sectors))
> + zone_info->nr_zones++;
> +
> + zone_info->seq_zones = bitmap_zalloc(zone_info->nr_zones, GFP_KERNEL);
> + if (!zone_info->seq_zones) {
> + ret = -ENOMEM;
> + goto out;
> + }
> +
> + zone_info->empty_zones = bitmap_zalloc(zone_info->nr_zones, GFP_KERNEL);
> + if (!zone_info->empty_zones) {
> + ret = -ENOMEM;
> + goto out;
> + }
> +
> + zones = kcalloc(BTRFS_REPORT_NR_ZONES,
> + sizeof(struct blk_zone), GFP_KERNEL);
> + if (!zones) {
> + ret = -ENOMEM;
> + goto out;
> + }
> +
> + /* Get zones type */
> + while (sector < nr_sectors) {
> + nr_zones = BTRFS_REPORT_NR_ZONES;
> + ret = btrfs_get_dev_zones(device, sector << SECTOR_SHIFT, zones,
> + &nr_zones);
> + if (ret)
> + goto out;
> +
> + for (i = 0; i < nr_zones; i++) {
> + if (zones[i].type == BLK_ZONE_TYPE_SEQWRITE_REQ)
> + set_bit(nreported, zone_info->seq_zones);
> + if (zones[i].cond == BLK_ZONE_COND_EMPTY)
> + set_bit(nreported, zone_info->empty_zones);
> + nreported++;
> + }
> + sector = zones[nr_zones - 1].start + zones[nr_zones - 1].len;
> + }
> +
> + if (nreported != zone_info->nr_zones) {
> + btrfs_err_in_rcu(device->fs_info,
> + "inconsistent number of zones on %s (%u / %u)",
> + rcu_str_deref(device->name), nreported,
> + zone_info->nr_zones);
> + ret = -EIO;
> + goto out;
> + }
> +
> + kfree(zones);
> +
> + device->zone_info = zone_info;
> +
> + devstr[0] = 0;
> + if (device->fs_info)
> + snprintf(devstr, sizeof(devstr), " (device %s)",
> + device->fs_info->sb->s_id);
> +
> + rcu_read_lock();
> + pr_info(
Why isn't this btrfs_info() ? Thanks,
Josef
next prev parent reply other threads:[~2020-11-02 16:53 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 13:51 [PATCH v9 00/41] btrfs: zoned block device support Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 01/41] block: add bio_add_zone_append_page Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 02/41] iomap: support REQ_OP_ZONE_APPEND Naohiro Aota
2020-11-02 5:34 ` Naohiro Aota
2020-11-02 16:55 ` Darrick J. Wong
2020-11-02 17:39 ` Johannes Thumshirn
2020-10-30 13:51 ` [PATCH v9 03/41] btrfs: introduce ZONED feature flag Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 04/41] btrfs: Get zone information of zoned block devices Naohiro Aota
2020-11-02 16:53 ` Josef Bacik [this message]
2020-11-02 16:58 ` Johannes Thumshirn
2020-11-02 21:07 ` Naohiro Aota
2020-11-03 12:02 ` David Sterba
2020-10-30 13:51 ` [PATCH v9 05/41] btrfs: Check and enable ZONED mode Naohiro Aota
2020-11-03 12:13 ` David Sterba
2020-11-06 9:36 ` Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 06/41] btrfs: introduce max_zone_append_size Naohiro Aota
2020-11-02 16:57 ` Josef Bacik
2020-11-03 12:16 ` David Sterba
2020-10-30 13:51 ` [PATCH v9 07/41] btrfs: disallow space_cache in ZONED mode Naohiro Aota
2020-11-02 17:02 ` Josef Bacik
2020-11-02 17:37 ` Johannes Thumshirn
2020-11-03 12:48 ` David Sterba
2020-11-10 10:14 ` Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 08/41] btrfs: disallow NODATACOW " Naohiro Aota
2020-11-02 17:05 ` Josef Bacik
2020-11-03 12:57 ` David Sterba
2020-10-30 13:51 ` [PATCH v9 09/41] btrfs: disable fallocate " Naohiro Aota
2020-11-03 13:00 ` David Sterba
2020-10-30 13:51 ` [PATCH v9 10/41] btrfs: disallow mixed-bg " Naohiro Aota
2020-11-03 13:01 ` David Sterba
2020-10-30 13:51 ` [PATCH v9 11/41] btrfs: implement log-structured superblock for " Naohiro Aota
2020-11-02 18:22 ` Josef Bacik
2020-11-02 18:53 ` Johannes Thumshirn
2020-11-02 19:01 ` Josef Bacik
2020-11-02 19:31 ` Johannes Thumshirn
2020-11-03 8:21 ` Naohiro Aota
2020-11-02 18:54 ` Josef Bacik
2020-11-03 3:31 ` Naohiro Aota
2020-11-03 13:15 ` David Sterba
2020-11-03 14:10 ` David Sterba
2020-11-06 10:37 ` Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 12/41] btrfs: implement zoned chunk allocator Naohiro Aota
2020-11-02 20:09 ` Josef Bacik
2020-11-02 22:21 ` Naohiro Aota
2020-11-03 13:23 ` David Sterba
2020-10-30 13:51 ` [PATCH v9 13/41] btrfs: verify device extent is aligned to zone Naohiro Aota
2020-11-02 20:14 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 14/41] btrfs: load zone's alloction offset Naohiro Aota
2020-11-02 20:25 ` Josef Bacik
2020-11-02 20:29 ` Josef Bacik
2020-11-02 22:43 ` Naohiro Aota
2020-11-02 22:40 ` Naohiro Aota
2020-11-03 13:28 ` David Sterba
2020-10-30 13:51 ` [PATCH v9 15/41] btrfs: emulate write pointer for conventional zones Naohiro Aota
2020-11-02 20:37 ` Josef Bacik
2020-11-03 1:25 ` Naohiro Aota
2020-11-03 13:32 ` David Sterba
2020-10-30 13:51 ` [PATCH v9 16/41] btrfs: track unusable bytes for zones Naohiro Aota
2020-11-03 14:25 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 17/41] btrfs: do sequential extent allocation in ZONED mode Naohiro Aota
2020-11-03 14:28 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 18/41] btrfs: reset zones of unused block groups Naohiro Aota
2020-11-03 14:34 ` Josef Bacik
2020-11-10 10:40 ` Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 19/41] btrfs: redirty released extent buffers in ZONED mode Naohiro Aota
2020-11-03 14:41 ` Josef Bacik
2020-11-06 9:11 ` Johannes Thumshirn
2020-11-06 15:01 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 20/41] btrfs: extract page adding function Naohiro Aota
2020-11-03 14:45 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 21/41] btrfs: use bio_add_zone_append_page for zoned btrfs Naohiro Aota
2020-11-03 14:55 ` Josef Bacik
2020-11-10 10:42 ` Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 22/41] btrfs: handle REQ_OP_ZONE_APPEND as writing Naohiro Aota
2020-11-03 14:57 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 23/41] btrfs: split ordered extent when bio is sent Naohiro Aota
2020-11-03 15:29 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 24/41] btrfs: extend btrfs_rmap_block for specifying a device Naohiro Aota
2020-11-03 15:32 ` Josef Bacik
2020-11-06 10:52 ` Johannes Thumshirn
2020-10-30 13:51 ` [PATCH v9 25/41] btrfs: use ZONE_APPEND write for ZONED btrfs Naohiro Aota
2020-11-03 15:55 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 26/41] btrfs: enable zone append writing for direct IO Naohiro Aota
2020-11-03 15:56 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 27/41] btrfs: introduce dedicated data write path for ZONED mode Naohiro Aota
2020-11-03 15:57 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 28/41] btrfs: serialize meta IOs on " Naohiro Aota
2020-11-03 16:04 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 29/41] btrfs: wait existing extents before truncating Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 30/41] btrfs: avoid async metadata checksum on ZONED mode Naohiro Aota
2020-11-03 16:05 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 31/41] btrfs: mark block groups to copy for device-replace Naohiro Aota
2020-11-03 17:09 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 32/41] btrfs: implement cloning for ZONED device-replace Naohiro Aota
2020-11-03 17:15 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 33/41] btrfs: implement copying " Naohiro Aota
2020-11-03 17:19 ` Josef Bacik
2020-11-10 11:09 ` Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 34/41] btrfs: support dev-replace in ZONED mode Naohiro Aota
2020-11-03 20:34 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 35/41] btrfs: enable relocation " Naohiro Aota
2020-11-03 20:39 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 36/41] btrfs: relocate block group to repair IO failure in ZONED Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 37/41] btrfs: split alloc_log_tree() Naohiro Aota
2020-11-03 20:42 ` Josef Bacik
2020-11-03 22:10 ` Amy Parker
2020-11-10 11:12 ` Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 38/41] btrfs: extend zoned allocator to use dedicated tree-log block group Naohiro Aota
2020-11-03 20:47 ` Josef Bacik
2020-11-10 6:37 ` Naohiro Aota
2020-10-30 13:51 ` [PATCH v9 39/41] btrfs: serialize log transaction on ZONED mode Naohiro Aota
2020-11-03 20:49 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 40/41] btrfs: reorder log node allocation Naohiro Aota
2020-11-03 20:49 ` Josef Bacik
2020-10-30 13:51 ` [PATCH v9 41/41] btrfs: enable to mount ZONED incompat flag Naohiro Aota
2020-10-31 3:40 ` [PATCH v9 01/41] block: add bio_add_zone_append_page Jens Axboe
2020-11-02 5:15 ` Naohiro Aota
2020-11-02 8:24 ` Johannes Thumshirn
2020-11-03 11:54 ` [PATCH v9 00/41] btrfs: zoned block device support David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69081702-5b34-1362-6e76-6769083a912c@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=damien.lemoal@wdc.com \
--cc=dsterba@suse.com \
--cc=hare@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.