From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Ian Jackson <ian.jackson@citrix.com>,
Anthony Perard <anthony.perard@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/4] build: work around bash issue
Date: Thu, 6 Aug 2020 15:57:38 +0100 [thread overview]
Message-ID: <6a7226b9-9702-9adc-c849-e21d27a8fced@citrix.com> (raw)
In-Reply-To: <df45f8af-a32b-67cf-2f56-4761ce263a28@suse.com>
On 06/08/2020 10:14, Jan Beulich wrote:
> On 06.08.2020 11:07, Julien Grall wrote:
>> On 06/08/2020 10:04, Jan Beulich wrote:
>>> Older bash fails to honor "set -e" for certain built-in commands
>> "Older" is pretty vague. May I ask the exact version you run into the issue?
> If I knew in what version the issue got fixed, I'd have specified
> that version. I've observed it with 3.2.57(2).
Its still very useful information for the commit message.
I tend to phrase something like this as "Older versions of bash (at
least, 3.2.57(2))" which gives a clear indication that the problem was
observed with the specified version, without suggesting that this is a
boundary of when the issue was introduced/fixed.
With this adjusted, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
to avoid a second posting.
~Andrew
next prev parent reply other threads:[~2020-08-06 14:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 9:02 [PATCH 0/4] build: corrections to .init.o generation logic Jan Beulich
2020-08-06 9:04 ` [PATCH 1/4] build: work around bash issue Jan Beulich
2020-08-06 9:07 ` Julien Grall
2020-08-06 9:14 ` Jan Beulich
2020-08-06 9:20 ` Julien Grall
2020-08-06 9:25 ` Jan Beulich
2020-08-06 9:44 ` Julien Grall
2020-08-06 14:57 ` Andrew Cooper [this message]
2020-08-06 9:05 ` [PATCH 2/4] build: correctly report non-empty section sizes upon .o -> .init.o conversion Jan Beulich
2020-08-06 15:25 ` Andrew Cooper
2020-08-06 9:05 ` [PATCH 3/4] build: also check for empty .bss.* in " Jan Beulich
2020-08-06 16:16 ` Andrew Cooper
2020-08-07 10:56 ` Jan Beulich
2020-08-07 15:12 ` Andrew Cooper
2020-08-07 15:40 ` Jan Beulich
2020-08-10 17:51 ` Andrew Cooper
2020-08-17 16:04 ` Jan Beulich
2020-08-10 17:51 ` Andrew Cooper
2020-08-14 19:28 ` Julien Grall
2020-08-06 9:06 ` [PATCH 4/4] EFI: free unused boot mem in at least some cases Jan Beulich
2020-08-10 17:09 ` Andrew Cooper
2020-08-14 15:14 ` David Woodhouse
2020-08-17 15:42 ` Jan Beulich
2020-08-25 10:57 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a7226b9-9702-9adc-c849-e21d27a8fced@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.