From: Eric Blake <eblake@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: berrange@redhat.com, armbru@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 2/4] qobject: introduce QObjectCommon
Date: Thu, 29 Mar 2018 11:15:18 -0500 [thread overview]
Message-ID: <6a82b9c0-61b2-83b8-75c5-c748bbde029e@redhat.com> (raw)
In-Reply-To: <20180329154833.566-3-marcandre.lureau@redhat.com>
On 03/29/2018 10:48 AM, Marc-André Lureau wrote:
> By moving the common fields to a QObjectCommon, QObject can be a type
> which also has a 'base' QObjectCommon field. This allows to write a
> generic QOBJECT() macro that will work with any QObject type,
> including QObject itself. The container_of() macro ensures that the
> object to cast has a QObjectCommon base field, give me some type
> safety guarantees. However, for it to work properly, all QObject types
> must have 'base' at offset 0 (which is ensured by static checking from
> previous patch)
Commit message should mention the rationale you gave in v2 of NOT using
a typedef for QObjectCommon (which was intentional so as to minimize the
chance that the type gets abused). We could even go so far as to name
it QObject_, with trailing underscore, rather than QObjectCommon, to
make it obvious it is not for normal use.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-03-29 16:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 15:48 [Qemu-devel] [PATCH v3 0/4] RFC: simplify qobject refcount Marc-André Lureau
2018-03-29 15:48 ` [Qemu-devel] [PATCH v3 1/4] qobject: ensure base is at offset 0 Marc-André Lureau
2018-03-29 15:48 ` [Qemu-devel] [PATCH v3 2/4] qobject: introduce QObjectCommon Marc-André Lureau
2018-03-29 16:15 ` Eric Blake [this message]
2018-03-29 15:48 ` [Qemu-devel] [PATCH v3 3/4] qobject: replace qobject_incref/QINCREF qobject_decref/QDECREF Marc-André Lureau
2018-03-29 16:23 ` Eric Blake
2018-04-13 16:13 ` Paolo Bonzini
2018-03-29 15:48 ` [Qemu-devel] [PATCH v3 4/4] qobject: modify qobject_ref() to assert on NULL and return obj Marc-André Lureau
2018-03-29 16:10 ` Eric Blake
2018-04-13 16:05 ` Marc-André Lureau
2018-03-31 6:26 ` [Qemu-devel] [PATCH v3 0/4] RFC: simplify qobject refcount no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a82b9c0-61b2-83b8-75c5-c748bbde029e@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.