From: Lucas Meneghel Rodrigues <lmr@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
Subject: Re: [Autotest] [KVM-AUTOTEST PATCH] fix an error of undefine variable
Date: Mon, 5 Oct 2009 14:49:12 -0300 [thread overview]
Message-ID: <6ac58f4f0910051049x3a8b190bnba60d7e55aa9dee5@mail.gmail.com> (raw)
In-Reply-To: <20090923023245.GA15693@dhcp-66-70-48.nay.redhat.com>
Hi Amos, thanks for the fix! It is fine, but to avoid introducing
global statements, I've worked out another patch to fix that issue.
Also, there was another undefined variable lying around (base_path).
I've finished up the patch and sent it to the mailing list!
Cheers,
On Tue, Sep 22, 2009 at 11:32 PM, Amos Kong <akong@redhat.com> wrote:
>
> Sorry for lost autotest@test.kernel.org. So send again. Thanks.
> ------------------------------------------------------
> fix an error of undefine variable
>
> 09/23 09:50:27 ERROR| traceback:0013| File "/usr/lib64/python2.4/logging/__init__.py", line 744, in emit
> 09/23 09:50:27 ERROR| traceback:0013| self.handleError(record)
> 09/23 09:50:27 ERROR| traceback:0013| File "/root/project/autotest/client/setup_modules.py", line 86, in _autotest_logging_handle_error
> 09/23 09:50:27 ERROR| traceback:0013| traceback.print_stack()
> 09/23 09:50:27 ERROR|setup_modu:0087| Future logging formatting exceptions disabled.
> 09/23 09:50:27 ERROR| kvm:0067| Test failed: global name 'root_module_name' is not defined
>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> client/setup_modules.py | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/client/setup_modules.py b/client/setup_modules.py
> index dc255c4..8b3200b 100644
> --- a/client/setup_modules.py
> +++ b/client/setup_modules.py
> @@ -86,7 +86,7 @@ def _autotest_logging_handle_error(self, record):
> traceback.print_stack()
> sys.stderr.write('Future logging formatting exceptions disabled.\n')
>
> - if root_module_name == 'autotest_lib':
> + if global_root_module_name == 'autotest_lib':
> # Allow locally installed third party packages to be found
> # before any that are installed on the system itself when not.
> # running as a client.
> @@ -124,6 +124,8 @@ def setup(base_path, root_module_name=""):
> The setup must be different if you are running on an Autotest server
> or on a test machine that just has the client directories installed.
> """
> + global global_root_module_name
> + global_root_module_name = root_module_name
> # Hack... Any better ideas?
> if (root_module_name == 'autotest_lib.client' and
> os.path.exists(os.path.join(os.path.dirname(__file__),
> --
> 1.5.5.6
>
> _______________________________________________
> Autotest mailing list
> Autotest@test.kernel.org
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>
--
Lucas
prev parent reply other threads:[~2009-10-05 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 2:16 [PATCH] fix an error of undefine variable Amos Kong
2009-09-23 2:32 ` [KVM-AUTOTEST PATCH] " Amos Kong
2009-10-05 17:49 ` Lucas Meneghel Rodrigues [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac58f4f0910051049x3a8b190bnba60d7e55aa9dee5@mail.gmail.com \
--to=lmr@redhat.com \
--cc=akong@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.