Re: [PATCH] drm/syncobj: Tune down unordered timeline DRM_ERROR

From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>
Cc: "Daniel Vetter" <daniel.vetter@intel.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Chris Wilson" <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/syncobj: Tune down unordered timeline DRM_ERROR
Date: Sat, 1 Aug 2020 17:39:50 +0300	[thread overview]
Message-ID: <6c320fd4-81d4-1a96-e83e-ecbdedfbd7f8@intel.com> (raw)
In-Reply-To: <20200801092625.1107609-1-daniel.vetter@ffwll.ch>

On 01/08/2020 12:26, Daniel Vetter wrote:
> Userspace can provoke this, we generally don't allow userspace to spam
> dmesg. Tune it down to debug. Unfortunately we don't have easy access
> to the drm_device here (not at all without changing a few things), so
> leave it as old style dmesg output for now.
>
> References: https://patchwork.freedesktop.org/series/80146/
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> ---
>   drivers/gpu/drm/drm_syncobj.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 3bf73971daf3..6e74e6745eca 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -297,7 +297,7 @@ void drm_syncobj_add_point(struct drm_syncobj *syncobj,
>   	prev = drm_syncobj_fence_get(syncobj);
>   	/* You are adding an unorder point to timeline, which could cause payload returned from query_ioctl is 0! */
>   	if (prev && prev->seqno >= point)
> -		DRM_ERROR("You are adding an unorder point to timeline!\n");
> +		DRM_DEBUG("You are adding an unorder point to timeline!\n");
>   	dma_fence_chain_init(chain, prev, fence, point);
>   	rcu_assign_pointer(syncobj->fence, &chain->base);
>   

Thanks,

Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel