From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: fam@euphon.net, Thomas Huth <thuth@redhat.com>,
berrange@redhat.com, Cornelia Huck <cohuck@redhat.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Willian Rampazzo <willianr@redhat.com>,
stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com,
aurelien@aurel32.net
Subject: Re: [PATCH v1 3/8] gitlab: add special rule for the hexagon container
Date: Tue, 25 May 2021 13:25:26 +0200 [thread overview]
Message-ID: <6c666ad7-828a-2d14-ebb4-98efd240d37d@amsat.org> (raw)
In-Reply-To: <3f5c486a-2f67-8f65-ef7d-5877c69e2399@amsat.org>
On 5/25/21 11:40 AM, Philippe Mathieu-Daudé wrote:
> On 5/20/21 7:42 PM, Alex Bennée wrote:
>> The hexagon container is always manually built but of course not
>> everyone will be building it themselves and pushing to their
>> registries. We still need to create a "local" registry copy for the
>> actual gitlab tests to run. We don't build it in this case, just pull
>> it across from the upstream registry. We disable this rule from
>> running on the qemu-project itself so it doesn't accidentally wipe out
>> our master copy.
>>
>> Fixes: 910c40ee94 ("gitlab: add build-user-hexagon test")
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Tested-by: Cornelia Huck <cohuck@redhat.com>
>> Reviewed-by: Willian Rampazzo <willianr@redhat.com>
>> Cc: Cornelia Huck <cohuck@redhat.com>
>>
>> ---
>> v2
>> - fix silly typo
>> ---
>> .gitlab-ci.d/containers.yml | 27 +++++++++++++++++++++++++++
>> .gitlab-ci.yml | 2 ++
>> 2 files changed, 29 insertions(+)
>>
>> diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml
>> index 3fb3c14f06..088c7e68c3 100644
>> --- a/.gitlab-ci.d/containers.yml
>> +++ b/.gitlab-ci.d/containers.yml
>> @@ -101,6 +101,33 @@ armhf-debian-cross-container:
>> variables:
>> NAME: debian-armhf-cross
>>
>> +# We never want to build hexagon in the CI system and by default we
>> +# always want to refer to the master registry where it lives.
>> +hexagon-cross-container:
>> + image: docker:stable
>> + stage: containers
>> + except:
>> + variables:
>> + - $CI_PROJECT_NAMESPACE == 'qemu-project'
>
> FYI Daniel said we should be consistent and use the 'rules:' syntax:
> https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg07308.html
Since our rule set default to 'always', this should be:
rules:
- if: '$CI_PROJECT_NAMESPACE == "qemu-project"'
when: always
- when: never
next prev parent reply other threads:[~2021-05-25 11:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 17:42 [PATCH v1 0/8] various misc fixes (gitlab, gdbstub, plugins) Alex Bennée
2021-05-20 17:42 ` [PATCH v1 1/8] tests/tcg: add a multiarch signals test to stress test signal delivery Alex Bennée
2021-05-24 21:05 ` Richard Henderson
2021-05-20 17:42 ` [PATCH v1 2/8] gitlab: explicitly reference the upstream registry Alex Bennée
2021-05-24 19:15 ` Willian Rampazzo
2021-05-25 4:04 ` Philippe Mathieu-Daudé
2021-05-20 17:42 ` [PATCH v1 3/8] gitlab: add special rule for the hexagon container Alex Bennée
2021-05-25 3:54 ` Philippe Mathieu-Daudé
2021-05-25 9:40 ` Philippe Mathieu-Daudé
2021-05-25 11:25 ` Philippe Mathieu-Daudé [this message]
2021-05-25 15:06 ` Alex Bennée
2021-05-20 17:42 ` [PATCH v1 4/8] gdbstub: Constify GdbCmdParseEntry Alex Bennée
2021-05-24 21:06 ` Richard Henderson
2021-05-20 17:43 ` [PATCH v1 5/8] gdbstub: Replace GdbCmdContext with plain g_array() Alex Bennée
2021-05-20 17:43 ` [PATCH v1 6/8] hmp-commands: expand type of icount to "l" in replay commands Alex Bennée
2021-05-25 3:55 ` Philippe Mathieu-Daudé
2021-05-20 17:43 ` [PATCH v1 7/8] gdbstub: tidy away reverse debugging check into function Alex Bennée
2021-05-24 21:08 ` Richard Henderson
2021-05-25 3:57 ` Philippe Mathieu-Daudé
2021-05-20 17:43 ` [PATCH v1 8/8] plugins/syscall: Added a table-like summary output Alex Bennée
2021-05-24 17:50 ` [PATCH v1 0/8] various misc fixes (gitlab, gdbstub, plugins) Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c666ad7-828a-2d14-ebb4-98efd240d37d@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=crosa@redhat.com \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.