From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH 4/4] SVM: clean up svm_vmcb_isvalid()
Date: Wed, 31 May 2017 10:50:44 -0400 [thread overview]
Message-ID: <6caf7c53-2dc6-a8d4-2eda-6c25254bad7d@oracle.com> (raw)
In-Reply-To: <e2032908-dc19-912b-223e-c56ae567f255@citrix.com>
On 05/31/2017 08:14 AM, Andrew Cooper wrote:
> On 31/05/17 08:23, Jan Beulich wrote:
>> - correct CR3 and CR4 checks
>> - add vcpu parameter (to include in log messages) and constify vmcb one
>> - use bool/true/false
>> - use accessors
>> - adjust formatting
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/xen/arch/x86/hvm/svm/nestedsvm.c
>> +++ b/xen/arch/x86/hvm/svm/nestedsvm.c
>> @@ -658,13 +658,13 @@ static int nsvm_vmcb_prepare4vmrun(struc
>> /* Cleanbits */
>> n2vmcb->cleanbits.bytes = 0;
>>
>> - rc = svm_vmcb_isvalid(__func__, ns_vmcb, 1);
>> + rc = svm_vmcb_isvalid(__func__, ns_vmcb, v, true);
>> if (rc) {
>> gdprintk(XENLOG_ERR, "virtual vmcb invalid\n");
>> return NSVM_ERROR_VVMCB;
>> }
>>
>> - rc = svm_vmcb_isvalid(__func__, n2vmcb, 1);
>> + rc = svm_vmcb_isvalid(__func__, n2vmcb, v, true);
> As these are the only two callsites, I don't think the __func__ or
> verbose parameters are useful. I'd just drop them.
I actually think keeping this is useful. We indeed have only two
invocations but someone debugging a problem may want to add a few more.
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-05-31 14:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 7:13 [PATCH 0/4] SVM: misc cleanup Jan Beulich
2017-05-31 7:21 ` [PATCH 1/4] SVM: use VMCB accessors Jan Beulich
2017-05-31 11:14 ` Andrew Cooper
2017-05-31 7:21 ` [PATCH 2/4] SVM: infer type in VMCB_ACCESSORS() Jan Beulich
2017-05-31 11:25 ` Andrew Cooper
2017-05-31 11:56 ` Jan Beulich
2017-05-31 14:32 ` Boris Ostrovsky
2017-05-31 7:22 ` [PATCH 3/4] SVM: clean up svm_vmcb_dump() Jan Beulich
2017-05-31 11:34 ` Andrew Cooper
2017-05-31 11:58 ` Jan Beulich
2017-05-31 7:23 ` [PATCH 4/4] SVM: clean up svm_vmcb_isvalid() Jan Beulich
2017-05-31 12:14 ` Andrew Cooper
2017-05-31 14:50 ` Boris Ostrovsky [this message]
2017-05-31 15:32 ` Andrew Cooper
2017-05-31 15:44 ` Boris Ostrovsky
2017-06-01 13:06 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6caf7c53-2dc6-a8d4-2eda-6c25254bad7d@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.